From 8d0962ca0cb076b3a5dafacc10c6a411b1e2d444 Mon Sep 17 00:00:00 2001 From: Timo Teräs Date: Tue, 20 Dec 2022 17:49:51 +0200 Subject: db: simplify reverse name list creation --- src/database.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/database.c b/src/database.c index 1a423dc..2ca5caf 100644 --- a/src/database.c +++ b/src/database.c @@ -483,29 +483,29 @@ static struct apk_db_file *apk_db_file_get(struct apk_database *db, return file; } +static void add_name_to_array(struct apk_name *name, struct apk_name_array **a) +{ + struct apk_name **n; + + foreach_array_item(n, *a) + if (*n == name) return; + *apk_name_array_add(a) = name; +} + static void apk_db_pkg_rdepends(struct apk_database *db, struct apk_package *pkg) { - struct apk_name *rname, **rd; + struct apk_name *rname; struct apk_dependency *d; foreach_array_item(d, pkg->depends) { rname = d->name; rname->is_dependency |= !d->conflict; - foreach_array_item(rd, rname->rdepends) - if (*rd == pkg->name) - goto rdeps_done; - *apk_name_array_add(&rname->rdepends) = pkg->name; -rdeps_done: ; + add_name_to_array(pkg->name, &rname->rdepends); } foreach_array_item(d, pkg->install_if) { rname = d->name; - foreach_array_item(rd, rname->rinstall_if) - if (*rd == pkg->name) - goto riif_done; - *apk_name_array_add(&rname->rinstall_if) = pkg->name; -riif_done: ; + add_name_to_array(pkg->name, &rname->rinstall_if); } - return; } static inline void add_provider(struct apk_name *name, struct apk_provider p) -- cgit v1.2.3-70-g09d2