From 5d19789a3b29d70ebfdbe18ac9c363390ff9eda9 Mon Sep 17 00:00:00 2001 From: Timo Teras Date: Tue, 11 Aug 2009 17:56:24 +0300 Subject: pkg, db: execute scripts from /var/cache/misc (fixes #129) --- src/package.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'src/package.c') diff --git a/src/package.c b/src/package.c index 3123834..33d6519 100644 --- a/src/package.c +++ b/src/package.c @@ -847,17 +847,22 @@ int apk_pkg_run_script(struct apk_package *pkg, int root_fd, if (script->type != type) continue; - snprintf(fn, sizeof(fn), "tmp/%s-%s.%s", + /* Avoid /tmp as it can be mounted noexec */ + snprintf(fn, sizeof(fn), "var/cache/misc/%s-%s.%s", pkg->name->name, pkg->version, apk_script_types[type]); - fd = openat(root_fd, fn, O_CREAT|O_RDWR|O_TRUNC, 0777); - if (fd < 0) - return fd; + fd = openat(root_fd, fn, O_CREAT|O_RDWR|O_TRUNC, 0755); + if (fd < 0) { + mkdirat(root_fd, "var/cache/misc", 0755); + fd = openat(root_fd, fn, O_CREAT|O_RDWR|O_TRUNC, 0755); + if (fd < 0) + return -errno; + } write(fd, script->script, script->size); close(fd); - apk_message("Executing %s", &fn[4]); + apk_message("Executing %s", &fn[15]); pid = fork(); if (pid == -1) -- cgit v1.2.3-60-g2f50