From 3448f3148f37bd246643be6669434c6c7f588c90 Mon Sep 17 00:00:00 2001 From: Timo Teräs Date: Sun, 25 Dec 2022 14:57:47 +0200 Subject: solver: prioritize user specified action on mentioned packages Force preference on the user specified action on commandline. This allows upgrading packages which would otherwise be kept back due to partial update preferring to keep top level dependency on the installed version. fixes #7531 --- src/apk_database.h | 1 + src/solver.c | 4 ++++ 2 files changed, 5 insertions(+) (limited to 'src') diff --git a/src/apk_database.h b/src/apk_database.h index f0f6ba5..5b495d8 100644 --- a/src/apk_database.h +++ b/src/apk_database.h @@ -102,6 +102,7 @@ struct apk_name { unsigned auto_select_virtual: 1; unsigned priority : 2; unsigned layer : 4; + unsigned solver_flags_set : 1; unsigned int foreach_genid; union { struct apk_solver_name_state ss; diff --git a/src/solver.c b/src/solver.c index 13dd8c6..7327b71 100644 --- a/src/solver.c +++ b/src/solver.c @@ -51,6 +51,7 @@ void apk_solver_set_name_flags(struct apk_name *name, { struct apk_provider *p; + name->solver_flags_set = 1; foreach_array_item(p, name->providers) { struct apk_package *pkg = p->pkg; dbg_printf("marking '" PKG_VER_FMT "' = 0x%04x / 0x%04x\n", @@ -1031,6 +1032,9 @@ static int compare_name_dequeue(const struct apk_name *a, const struct apk_name { int r; + r = !!(a->solver_flags_set) - !!(b->solver_flags_set); + if (r) return -r; + r = (int)a->priority - (int)b->priority; if (r) return r; -- cgit v1.2.3-70-g09d2