From a5d9e2eb0acadf6a04670f226a4246934b9997c6 Mon Sep 17 00:00:00 2001 From: William Pitcock Date: Tue, 20 Feb 2018 22:22:02 +0000 Subject: add: child dependencies can never take a pinning, give a useful error --- src/add.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/add.c b/src/add.c index 0f12132..a28425e 100644 --- a/src/add.c +++ b/src/add.c @@ -136,9 +136,10 @@ static int add_main(void *ctx, struct apk_database *db, struct apk_string_array apk_blob_t b = APK_BLOB_STR(*parg); apk_blob_pull_dep(&b, db, &dep); - if (APK_BLOB_IS_NULL(b) || b.len > 0) { - apk_error("'%s' is not a valid dependency, format is name(@tag)([<>~=]version)", - *parg); + if (APK_BLOB_IS_NULL(b) || b.len > 0 || (virtpkg != NULL && dep.repository_tag)) { + apk_error("'%s' is not a valid %s dependency, format is %s", + *parg, virtpkg == NULL ? "world" : "child", + virtpkg == NULL ? "name(@tag)([<>~=]version)" : "name([<>~=]version)"); return -1; } } -- cgit v1.2.3-70-g09d2