From c8d848cc58423b77df88e518e5bd5488cd59aa70 Mon Sep 17 00:00:00 2001 From: "A. Wilcox" Date: Sat, 21 Oct 2023 00:01:05 -0500 Subject: Qt UI: Use sudo to launch Partition Manager I'm not happy about relying on sudo either, but there's no other good way. Fixes: #368 --- CHANGELOG.rst | 19 +++++++++++++++++++ ui/qt5/intropage.cc | 2 +- ui/qt5/netdhcppage.cc | 2 +- ui/qt5/partitionmanualpage.cc | 2 +- 4 files changed, 22 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 78a7177..e5d4deb 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -64,6 +64,23 @@ Image Creation * CD backend generated GRUB configuration files are now readable on 64-bit PowerPC systems utilising the Petitboot boot loader. +* All images now support both graphical and text mode options in the GRUB + menu, allowing to skip loading X11 on systems where it does not work. + + +Metadata +-------- + +* The ``svcenable`` key now supports non-system runlevels. All runlevels that + are not recognised as system runlevels will be "stacked" with the default + runlevel. You can utilise these runlevels by passing the ``softlevel=NAME`` + parameter to the kernel command line, where ``NAME`` is the name of the + desired runlevel. + +* The default values for ``signingkey`` use the distfiles mirror instead + of copies of the key on local disk. This allows you to use System + Installation from non-Adélie Linux systems. + Qt UI ----- @@ -89,6 +106,8 @@ Qt UI * The Qt script runner now uses the same high-DPI scaling setting used by the rest of System Installation. +* The Qt script runner will now display any errors encountered starting xterm. + 0.9.7 (2022-09-04) diff --git a/ui/qt5/intropage.cc b/ui/qt5/intropage.cc index f36e1fb..ab21657 100644 --- a/ui/qt5/intropage.cc +++ b/ui/qt5/intropage.cc @@ -48,7 +48,7 @@ IntroPage::IntroPage(QWidget *parent) : HorizonWizardPage(parent) { }); connect(toolMenu->addAction("&Partition Editor"), &QAction::triggered, [=](void) { QProcess *p = new QProcess(this); - p->start("partitionmanager", QStringList()); + p->start("sudo", {"/usr/bin/partitionmanager"}); horizonWizard()->tools.push_back(p); }); connect(toolMenu->addAction("&Web Browser"), &QAction::triggered, [=](void){ diff --git a/ui/qt5/netdhcppage.cc b/ui/qt5/netdhcppage.cc index 72061c9..8f4a474 100644 --- a/ui/qt5/netdhcppage.cc +++ b/ui/qt5/netdhcppage.cc @@ -63,7 +63,7 @@ void NetDHCPPage::startDHCP() { dhcpcd->setArguments({"-q", "-t", "15", "-n", "-j", "/var/log/horizon/dhcpcd.log", iface}); connect(dhcpcd, &QProcess::errorOccurred, - [=](QProcess::ProcessError error) { + [this](QProcess::ProcessError error) { progress->setStepStatus(0, StepProgressWidget::Failed); if(error == QProcess::FailedToStart) { information->setText(tr("The Installation Environment is missing a critical component. dhcpcd could not be loaded.")); diff --git a/ui/qt5/partitionmanualpage.cc b/ui/qt5/partitionmanualpage.cc index 548421b..b9c2d55 100644 --- a/ui/qt5/partitionmanualpage.cc +++ b/ui/qt5/partitionmanualpage.cc @@ -38,7 +38,7 @@ PartitionManualPage::PartitionManualPage(QWidget *parent) button->setWhatsThis(tr("Opens the partition editor.")); connect(button, &QPushButton::clicked, [=]{ QProcess p; - p.execute("partitionmanager", QStringList()); + p.execute("sudo", {"/usr/bin/partitionmanager"}); }); layout->addStretch(); layout->addWidget(button, 0, Qt::AlignCenter); -- cgit v1.2.3-70-g09d2