From be8b59280569a00d0f32f3953e358e4b8c0c0e1a Mon Sep 17 00:00:00 2001 From: "A. Wilcox" Date: Fri, 29 Nov 2019 18:16:42 -0600 Subject: Qt UI: Change Firmware default to Yes (READ ENTIRE COMMIT MSG BEFORE FLAMING) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There will be two Horizon media types: Firmware, and Libre. The user will be choosing the media type before downloading an Adélie Linux CD / USB image. If they choose Firmware, the system will automatically load firmware before beginning. This is to facilitate graphics cards that won't even bring up the framebuffer without firmware loaded (most recent GeForces, and all AMDGPUs, behave this way). This means the user will already be running firmware before the wizard is running. If we default to No, and the user doesn't understand the question, they may be left without a functional computer after installation because their GPU may still require firmware. If this is the case, it will be extremely difficult to recover. Therefore, the default should be Yes, so that users who have already consented to running firmware on their systems (by using the Firmware media type) will have the same choice made for them by default in the target. --- ui/qt5/firmwarepage.cc | 1 + 1 file changed, 1 insertion(+) (limited to 'ui') diff --git a/ui/qt5/firmwarepage.cc b/ui/qt5/firmwarepage.cc index b1f8717..30e4247 100644 --- a/ui/qt5/firmwarepage.cc +++ b/ui/qt5/firmwarepage.cc @@ -29,6 +29,7 @@ FirmwarePage::FirmwarePage(QWidget *parent) : HorizonWizardPage(parent) { noButton = new QRadioButton(tr("&No, do not load firmware on this computer.")); yesButton = new QRadioButton(tr("&Yes, load firmware on this computer.")); + yesButton->setChecked(true); firmwareChoice = new QButtonGroup; firmwareChoice->addButton(noButton); firmwareChoice->addButton(yesButton); -- cgit v1.2.3-60-g2f50