From 0f5425767964262062a6ef3791e9c797c653ef36 Mon Sep 17 00:00:00 2001 From: "A. Wilcox" Date: Mon, 7 Dec 2020 21:06:38 -0600 Subject: ietf-interfaces: Simplyify logic a bit Since we process the tag already, just remove it from the interface node entirely. This means we don't have to 'filter' on it later in the for loop, saving cycles during iteration. --- ncserver/module/interfaces.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'ncserver/module/interfaces.py') diff --git a/ncserver/module/interfaces.py b/ncserver/module/interfaces.py index 62aa91c..299a000 100644 --- a/ncserver/module/interfaces.py +++ b/ncserver/module/interfaces.py @@ -14,7 +14,7 @@ import logging import pathlib import subprocess -from lxml import etree +from lxml.etree import QName # pylint: disable=E0611 from netconf import error, util from ncserver.base.log import log_config_change @@ -23,9 +23,6 @@ from ncserver.base.util import _, node_operation, yang_dt_for_timestamp from ncserver.util import maybe_raise_on_invalid_node -QName = etree.QName # pylint: disable=I1101 - - LOGGER = logging.getLogger(__name__) """The object used for logging informational messages.""" @@ -303,6 +300,7 @@ def edit(session, rpc, node, def_op): if name_node is None: raise error.MissingElementAppError(rpc, interface) iface = name_node.text + interface.remove(name_node) operation = node_operation(interface, def_op) if operation in ('create', 'delete', 'remove'): @@ -329,7 +327,5 @@ def edit(session, rpc, node, def_op): name = QName(candidate.tag).localname if name in methods: methods[name](session, rpc, candidate, operation, iface) - elif name == 'name': - continue else: maybe_raise_on_invalid_node(M_NS, rpc, candidate) -- cgit v1.2.3-60-g2f50