From cf5e3c7c71d481c4c5005c8353587dccea4238fa Mon Sep 17 00:00:00 2001 From: "A. Wilcox" Date: Fri, 29 Dec 2017 02:44:11 -0600 Subject: user/plasma-workspace: fix crash on wallpaper change --- .../fix-crash-on-wallpaper-change.patch | 58 ++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 user/plasma-workspace/fix-crash-on-wallpaper-change.patch (limited to 'user/plasma-workspace/fix-crash-on-wallpaper-change.patch') diff --git a/user/plasma-workspace/fix-crash-on-wallpaper-change.patch b/user/plasma-workspace/fix-crash-on-wallpaper-change.patch new file mode 100644 index 000000000..078a48e3a --- /dev/null +++ b/user/plasma-workspace/fix-crash-on-wallpaper-change.patch @@ -0,0 +1,58 @@ +From a44d84ef47492ca60ee608996b5ab1f2849ef16e Mon Sep 17 00:00:00 2001 +From: David Edmundson +Date: Mon, 14 Aug 2017 10:04:19 +0100 +Subject: Don't change fillMode of image just before deleting it + +It is still set for when a source is applied for the next +transistion. + +Summary: +This saves evaluating a new paintedSize and doing a bunch of evaluations +which are not used. + +More importantly it works round a Qt animation crash. + +fadeAnim.running is bound to otherImage.status !== loading + +with the intention of delaying animations until the images are really +loaded. + +By setting the fill mode and then the source, we go to loading and back, +effectively restarting the animation from within the animation. +This leads to a crash. + +CCBUG: 381105 + +Test Plan: +End user result is the same. + +Reviewers: #plasma, broulik, mart + +Reviewed By: #plasma, broulik, mart + +Subscribers: plasma-devel + +Tags: #plasma + +Differential Revision: https://phabricator.kde.org/D7248 +--- + wallpapers/image/imagepackage/contents/ui/main.qml | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/wallpapers/image/imagepackage/contents/ui/main.qml b/wallpapers/image/imagepackage/contents/ui/main.qml +index fc22176..0539f37 100644 +--- a/wallpapers/image/imagepackage/contents/ui/main.qml ++++ b/wallpapers/image/imagepackage/contents/ui/main.qml +@@ -193,8 +193,8 @@ Item { + } + ScriptAction { + script: { +- otherImage.fillMode = fillMode; + otherImage.source = ""; ++ otherImage.fillMode = fillMode; + } + } + } +-- +cgit v0.11.2 + -- cgit v1.2.3-60-g2f50