Subject: Fix compilation with different ucontext_t on musl Upstream: No Author: Simon Frankenberger <simon-alpine@fraho.eu> The machine state registers have to be accessed differently when running on musl libc. This patch fix this by replacing "uc_mcontext.regs->grp" with "uc_mcontext.gp_regs" and accessing the named fields (like "->nip") by the array index constants. --- openjdk/hotspot/src/cpu/ppc/vm/macroAssembler_ppc.cpp +++ openjdk/hotspot/src/cpu/ppc/vm/macroAssembler_ppc.cpp @@ -1243,7 +1243,11 @@ bool MacroAssembler::is_load_from_polling_page(int instruction, void* ucontext, // the safepoing polling page. ucontext_t* uc = (ucontext_t*) ucontext; // Set polling address. +#if defined(__GLIBC__) || defined(__UCLIBC__) address addr = (address)uc->uc_mcontext.regs->gpr[ra] + (ssize_t)ds; +#else // Musl + address addr = (address)uc->uc_mcontext.gp_regs[ra] + (ssize_t)ds; +#endif if (polling_address_ptr != NULL) { *polling_address_ptr = addr; } @@ -1264,15 +1268,24 @@ bool MacroAssembler::is_memory_serialization(int instruction, JavaThread* thread int rb = inv_rb_field(instruction); // look up content of ra and rb in ucontext +#if defined(__GLIBC__) || defined(__UCLIBC__) address ra_val=(address)uc->uc_mcontext.regs->gpr[ra]; long rb_val=(long)uc->uc_mcontext.regs->gpr[rb]; +#else // Musl + address ra_val=(address)uc->uc_mcontext.gp_regs[ra]; + long rb_val=(long)uc->uc_mcontext.gp_regs[rb]; +#endif return os::is_memory_serialize_page(thread, ra_val+rb_val); } else if (is_stw(instruction) || is_stwu(instruction)) { int ra = inv_ra_field(instruction); int d1 = inv_d1_field(instruction); // look up content of ra in ucontext +#if defined(__GLIBC__) || defined(__UCLIBC__) address ra_val=(address)uc->uc_mcontext.regs->gpr[ra]; +#else // Musl + address ra_val=(address)uc->uc_mcontext.gp_regs[ra]; +#endif return os::is_memory_serialize_page(thread, ra_val+d1); } else { return false; @@ -1335,11 +1348,20 @@ address MacroAssembler::get_stack_bang_address(int instruction, void *ucontext) || (is_stdu(instruction) && rs == 1)) { int ds = inv_ds_field(instruction); // return banged address +#if defined(__GLIBC__) || defined(__UCLIBC__) return ds+(address)uc->uc_mcontext.regs->gpr[ra]; +#else // Musl + return ds+(address)uc->uc_mcontext.gp_regs[ra]; +#endif } else if (is_stdux(instruction) && rs == 1) { int rb = inv_rb_field(instruction); +#if defined(__GLIBC__) || defined(__UCLIBC__) address sp = (address)uc->uc_mcontext.regs->gpr[1]; long rb_val = (long)uc->uc_mcontext.regs->gpr[rb]; +#else // Musl + address sp = (address)uc->uc_mcontext.gp_regs[1]; + long rb_val = (long)uc->uc_mcontext.gp_regs[rb]; +#endif return ra != 1 || rb_val >= 0 ? NULL // not a stack bang : sp + rb_val; // banged address } --- openjdk/hotspot/src/os_cpu/linux_ppc/vm/os_linux_ppc.cpp +++ openjdk/hotspot/src/os_cpu/linux_ppc/vm/os_linux_ppc.cpp @@ -75,6 +75,10 @@ # include <poll.h> # include <ucontext.h> +#if ! (defined(__GLIBC__) || defined(__UCLIBC__)) +# include <asm/ptrace.h> +#endif + address os::current_stack_pointer() { intptr_t* csp; @@ -110,11 +114,19 @@ address os::Linux::ucontext_get_pc(ucontext_t * uc) { // it because the volatile registers are not needed to make setcontext() work. // Hopefully it was zero'd out beforehand. guarantee(uc->uc_mcontext.regs != NULL, "only use ucontext_get_pc in sigaction context"); +#if defined(__GLIBC__) || defined(__UCLIBC__) return (address)uc->uc_mcontext.regs->nip; +#else // Musl + return (address)uc->uc_mcontext.gp_regs[PT_NIP]; +#endif } intptr_t* os::Linux::ucontext_get_sp(ucontext_t * uc) { +#if defined(__GLIBC__) || defined(__UCLIBC__) return (intptr_t*)uc->uc_mcontext.regs->gpr[1/*REG_SP*/]; +#else // Musl + return (intptr_t*)uc->uc_mcontext.gp_regs[1/*REG_SP*/]; +#endif } intptr_t* os::Linux::ucontext_get_fp(ucontext_t * uc) { @@ -213,7 +225,11 @@ JVM_handle_linux_signal(int sig, if (uc) { address const pc = os::Linux::ucontext_get_pc(uc); if (pc && StubRoutines::is_safefetch_fault(pc)) { +#if defined(__GLIBC__) || defined(__UCLIBC__) uc->uc_mcontext.regs->nip = (unsigned long)StubRoutines::continuation_for_safefetch_fault(pc); +#else // Musl + uc->uc_mcontext.gp_regs[PT_NIP] = (unsigned long)StubRoutines::continuation_for_safefetch_fault(pc); +#endif return true; } } @@ -364,7 +380,11 @@ JVM_handle_linux_signal(int sig, // continue at the next instruction after the faulting read. Returning // garbage from this read is ok. thread->set_pending_unsafe_access_error(); +#if defined(__GLIBC__) || defined(__UCLIBC__) uc->uc_mcontext.regs->nip = ((unsigned long)pc) + 4; +#else // Musl + uc->uc_mcontext.gp_regs[PT_NIP] = ((unsigned long)pc) + 4; +#endif return true; } } @@ -383,7 +403,11 @@ JVM_handle_linux_signal(int sig, // continue at the next instruction after the faulting read. Returning // garbage from this read is ok. thread->set_pending_unsafe_access_error(); +#if defined(__GLIBC__) || defined(__UCLIBC__) uc->uc_mcontext.regs->nip = ((unsigned long)pc) + 4; +#else // Musl + uc->uc_mcontext.gp_regs[PT_NIP] = ((unsigned long)pc) + 4; +#endif return true; } } @@ -406,7 +430,11 @@ JVM_handle_linux_signal(int sig, if (stub != NULL) { // Save all thread context in case we need to restore it. if (thread != NULL) thread->set_saved_exception_pc(pc); +#if defined(__GLIBC__) || defined(__UCLIBC__) uc->uc_mcontext.regs->nip = (unsigned long)stub; +#else + uc->uc_mcontext.gp_regs[PT_NIP] = (unsigned long)stub; +#endif return true; } @@ -564,6 +592,7 @@ void os::print_context(outputStream *st, void *context) { ucontext_t* uc = (ucontext_t*)context; st->print_cr("Registers:"); +#if defined(__GLIBC__) || defined(__UCLIBC__) st->print("pc =" INTPTR_FORMAT " ", uc->uc_mcontext.regs->nip); st->print("lr =" INTPTR_FORMAT " ", uc->uc_mcontext.regs->link); st->print("ctr=" INTPTR_FORMAT " ", uc->uc_mcontext.regs->ctr); @@ -572,6 +601,16 @@ void os::print_context(outputStream *st, void *context) { st->print("r%-2d=" INTPTR_FORMAT " ", i, uc->uc_mcontext.regs->gpr[i]); if (i % 3 == 2) st->cr(); } +#else // Musl + st->print("pc =" INTPTR_FORMAT " ", uc->uc_mcontext.gp_regs[PT_NIP]); + st->print("lr =" INTPTR_FORMAT " ", uc->uc_mcontext.gp_regs[PT_LNK]); + st->print("ctr=" INTPTR_FORMAT " ", uc->uc_mcontext.gp_regs[PT_CTR]); + st->cr(); + for (int i = 0; i < 32; i++) { + st->print("r%-2d=" INTPTR_FORMAT " ", i, uc->uc_mcontext.gp_regs[i]); + if (i % 3 == 2) st->cr(); + } +#endif st->cr(); st->cr(); @@ -600,7 +639,11 @@ void os::print_register_info(outputStream *st, void *context) { // this is only for the "general purpose" registers for (int i = 0; i < 32; i++) { st->print("r%-2d=", i); +#if defined(__GLIBC__) || defined(__UCLIBC__) print_location(st, uc->uc_mcontext.regs->gpr[i]); +#else // Musl + print_location(st, uc->uc_mcontext.gp_regs[i]); +#endif } st->cr(); } --- openjdk/hotspot/src/os_cpu/linux_ppc/vm/thread_linux_ppc.cpp +++ openjdk/hotspot/src/os_cpu/linux_ppc/vm/thread_linux_ppc.cpp @@ -27,6 +27,10 @@ #include "runtime/frame.inline.hpp" #include "runtime/thread.hpp" +#if ! (defined(__GLIBC__) || defined(__UCLIBC__)) +#include <asm/ptrace.h> +#endif + bool JavaThread::pd_get_top_frame_for_profiling(frame* fr_addr, void* ucontext, bool isInJava) { assert(this->is_Java_thread(), "must be JavaThread"); @@ -42,8 +46,13 @@ bool JavaThread::pd_get_top_frame_for_profiling(frame* fr_addr, void* ucontext, // if we were running Java code when SIGPROF came in. if (isInJava) { ucontext_t* uc = (ucontext_t*) ucontext; +#if defined(__GLIBC__) || defined(__UCLIBC__) frame ret_frame((intptr_t*)uc->uc_mcontext.regs->gpr[1/*REG_SP*/], (address)uc->uc_mcontext.regs->nip); +#else // Musl + frame ret_frame((intptr_t*)uc->uc_mcontext.gp_regs[1/*REG_SP*/], + (address)uc->uc_mcontext.gp_regs[PT_NIP]); +#endif if (ret_frame.pc() == NULL) { // ucontext wasn't useful @@ -56,7 +65,11 @@ bool JavaThread::pd_get_top_frame_for_profiling(frame* fr_addr, void* ucontext, if (m == NULL || !m->is_valid_method()) return false; if (!Metaspace::contains((const void*)m)) return false; +#if defined(__GLIBC__) || defined(__UCLIBC__) uint64_t reg_bcp = uc->uc_mcontext.regs->gpr[14/*R14_bcp*/]; +#else // Musl + uint64_t reg_bcp = uc->uc_mcontext.gp_regs[14/*R14_bcp*/]; +#endif uint64_t istate_bcp = istate->bcp; uint64_t code_start = (uint64_t)(m->code_base()); uint64_t code_end = (uint64_t)(m->code_base() + m->code_size());