From 0636fdbfefecb404494fe6e2aed6d576b2196373 Mon Sep 17 00:00:00 2001
From: Massimiliano Culpo <massimiliano.culpo@gmail.com>
Date: Thu, 26 May 2022 16:35:20 +0200
Subject: Remove the warning that Spack prints at each spec (#30872)
Add instead a warning box in the documentation
---
lib/spack/docs/binary_caches.rst | 7 +++++++
lib/spack/spack/binary_distribution.py | 3 ---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/spack/docs/binary_caches.rst b/lib/spack/docs/binary_caches.rst
index 33fc61a96a..7c41485df8 100644
--- a/lib/spack/docs/binary_caches.rst
+++ b/lib/spack/docs/binary_caches.rst
@@ -50,6 +50,13 @@ build cache files for the "ninja" spec:
Note that the targeted spec must already be installed. Once you have a build cache,
you can add it as a mirror, discussed next.
+.. warning::
+
+ Spack improved the format used for binary caches in v0.18. The entire v0.18 series
+ will be able to verify and install binary caches both in the new and in the old format.
+ Support for using the old format is expected to end in v0.19, so we advise users to
+ recreate relevant buildcaches using Spack v0.18 or higher.
+
---------------------------------------
Finding or installing build cache files
---------------------------------------
diff --git a/lib/spack/spack/binary_distribution.py b/lib/spack/spack/binary_distribution.py
index fb4c6ce472..a0b0e75b83 100644
--- a/lib/spack/spack/binary_distribution.py
+++ b/lib/spack/spack/binary_distribution.py
@@ -1600,9 +1600,6 @@ def extract_tarball(spec, download_result, allow_root=False, unsigned=False,
# Handle the older buildcache layout where the .spack file
# contains a spec json/yaml, maybe an .asc file (signature),
# and another tarball containing the actual install tree.
- tty.warn("This binary package uses a deprecated layout, "
- "and support for it will eventually be removed "
- "from spack.")
tmpdir = tempfile.mkdtemp()
try:
tarfile_path = _extract_inner_tarball(
--
cgit v1.2.3-70-g09d2