From 272c7c069a9d148b55a531316c397eaf179f5574 Mon Sep 17 00:00:00 2001 From: Dom Heinzeller Date: Fri, 3 May 2024 12:38:33 -0600 Subject: Add -fPIC to hdf-eos2 builds (#43794) * Add -fPIC to hdf-eos2 builds * Use self.compiler.cc_pic_flag instead of -fPIC * Fix style in var/spack/repos/builtin/packages/hdf-eos2/package.py --- var/spack/repos/builtin/packages/hdf-eos2/package.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/var/spack/repos/builtin/packages/hdf-eos2/package.py b/var/spack/repos/builtin/packages/hdf-eos2/package.py index 3eb9b7477b..76d8239934 100644 --- a/var/spack/repos/builtin/packages/hdf-eos2/package.py +++ b/var/spack/repos/builtin/packages/hdf-eos2/package.py @@ -160,4 +160,15 @@ class HdfEos2(AutotoolsPackage): if "zlib" in self.spec: extra_args.append("--with-zlib={0}".format(self.spec["zlib-api"].prefix)) + # https://forum.hdfgroup.org/t/help-building-hdf4-with-clang-error-implicit-declaration-of-function-test-mgr-szip-is-invalid-in-c99/7680 + # -fPIC: https://github.com/spack/spack/issues/43792 + if self.spec.satisfies("%apple-clang"): + extra_args.append( + "CFLAGS=-Wno-error=implicit-function-declaration {0}".format( + self.compiler.cc_pic_flag + ) + ) + else: + extra_args.append("CFLAGS={0}".format(self.compiler.cc_pic_flag)) + return extra_args -- cgit v1.2.3-70-g09d2