From 3477d578a3a7d456a790e72755cbac456da99cb1 Mon Sep 17 00:00:00 2001 From: Brian Van Essen Date: Thu, 15 Dec 2022 14:29:36 -0800 Subject: roctracer: fixed a bug in how the external is identified (#33517) Make the package a proper ROCm package. --- var/spack/repos/builtin/packages/roctracer-dev/package.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/var/spack/repos/builtin/packages/roctracer-dev/package.py b/var/spack/repos/builtin/packages/roctracer-dev/package.py index c971638c45..3d0764976d 100644 --- a/var/spack/repos/builtin/packages/roctracer-dev/package.py +++ b/var/spack/repos/builtin/packages/roctracer-dev/package.py @@ -8,7 +8,7 @@ import re from spack.package import * -class RoctracerDev(CMakePackage): +class RoctracerDev(CMakePackage, ROCmPackage): """ROC-tracer library: Runtimes Generic Callback/Activity APIs. The goal of the implementation is to provide a generic independent from specific runtime profiler to trace API and asyncronous activity.""" @@ -81,7 +81,7 @@ class RoctracerDev(CMakePackage): @classmethod def determine_version(cls, lib): - match = re.search(r"lib\S*\.so\.\d+\.\d+\.(\d)(\d\d)(\d\d)", lib) + match = re.search(r"rocm-(\d+)\.(\d+)\.(\d)/lib/lib\S*\.so\.\d+\.\d+\.\d+", lib) if match: ver = "{0}.{1}.{2}".format( int(match.group(1)), int(match.group(2)), int(match.group(3)) @@ -90,10 +90,6 @@ class RoctracerDev(CMakePackage): ver = None return ver - def setup_build_environment(self, build_env): - spec = self.spec - build_env.set("HIP_PATH", spec["hip"].prefix), - def patch(self): filter_file( "${CMAKE_PREFIX_PATH}/hsa", -- cgit v1.2.3-60-g2f50