From 3903658bfc8e53c89ebde593d762cb8fb732129a Mon Sep 17 00:00:00 2001
From: Todd Gamblin <tgamblin@llnl.gov>
Date: Thu, 9 May 2019 23:52:39 -0700
Subject: coverage: only run coverage for subset of unit tests

- Codecov cannot handle as many coverage reports as we are generating

- as a result, our PR coverage pages have been broken for a while, and
  it's hard to tell people where to enhance their testing in PR reviews.

- Scale back to only running coverage for 3.7 and 2.7 unit tests

- This is *probably* better.  We run the build tests for good measure,
  but we do not need to evaluate them for coverage.  The coverage reports
  are about unit tests.
---
 .travis.yml             | 6 +++---
 share/spack/qa/setup.sh | 9 +++++----
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 694ada8cc3..e506712464 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -34,7 +34,7 @@ jobs:
       sudo: required
       os: linux
       language: python
-      env: TEST_SUITE=unit
+      env: [ TEST_SUITE=unit, COVERAGE=true ]
     - python: '3.4'
       sudo: required
       os: linux
@@ -54,7 +54,7 @@ jobs:
       sudo: required
       os: linux
       language: python
-      env: TEST_SUITE=unit
+      env: [ TEST_SUITE=unit, COVERAGE=true ]
       addons:
         apt:
           packages:
@@ -80,7 +80,7 @@ jobs:
       env: TEST_SUITE=doc
     - os: osx
       language: generic
-      env: [ TEST_SUITE=unit, PYTHON_VERSION=2.7 ]
+      env: [ TEST_SUITE=unit, PYTHON_VERSION=2.7, COVERAGE=true ]
 # mpich (AutotoolsPackage)
     - stage: 'build tests'
       python: '2.7'
diff --git a/share/spack/qa/setup.sh b/share/spack/qa/setup.sh
index f6132c3ec9..6256269211 100755
--- a/share/spack/qa/setup.sh
+++ b/share/spack/qa/setup.sh
@@ -16,8 +16,12 @@ export SPACK_ROOT=$(realpath "$QA_DIR/../../..")
 # Source the setup script
 . "$SPACK_ROOT/share/spack/setup-env.sh"
 
+# by default coverage is off.
+coverage=""
+coverage_run=""
+
 # Set up some variables for running coverage tests.
-if [[ "$TEST_SUITE" == "unit" || "$TEST_SUITE" == "build" ]]; then
+if [[ "$COVERAGE" == "true" ]]; then
     # these set up coverage for Python
     coverage=coverage
     coverage_run="coverage run"
@@ -33,9 +37,6 @@ if [[ "$TEST_SUITE" == "unit" || "$TEST_SUITE" == "build" ]]; then
         bashcov=$(realpath ${QA_DIR}/bashcov)
         sed -i~ "s@#\!/bin/bash@#\!${bashcov}@" "$cc_script"
     fi
-else
-    coverage=""
-    coverage_run=""
 fi
 
 #
-- 
cgit v1.2.3-70-g09d2