From 411576e1fa125b7eb58f816c2d2b6da0bcb95555 Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Fri, 5 Apr 2024 12:31:21 +0200 Subject: Do not acquire a write lock on the env post install if no views (#43505) --- lib/spack/spack/cmd/install.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/spack/spack/cmd/install.py b/lib/spack/spack/cmd/install.py index aa958a682c..755fab7fa6 100644 --- a/lib/spack/spack/cmd/install.py +++ b/lib/spack/spack/cmd/install.py @@ -420,10 +420,9 @@ def install_with_active_env(env: ev.Environment, args, install_kwargs, reporter_ with reporter_factory(specs_to_install): env.install_specs(specs_to_install, **install_kwargs) finally: - # TODO: this is doing way too much to trigger - # views and modules to be generated. - with env.write_transaction(): - env.write(regenerate=True) + if env.views: + with env.write_transaction(): + env.write(regenerate=True) def concrete_specs_from_cli(args, install_kwargs): -- cgit v1.2.3-70-g09d2