From 6d3541c5fd71e87f1eaf1f6045dbe818ea9c1a7e Mon Sep 17 00:00:00 2001 From: afzpatel <122491982+afzpatel@users.noreply.github.com> Date: Tue, 16 Jul 2024 15:39:08 -0400 Subject: fix hipblas test (#44666) * fix hipblas test * add rocm-openmp-extras dependencies --- var/spack/repos/builtin/packages/hipblas/package.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/var/spack/repos/builtin/packages/hipblas/package.py b/var/spack/repos/builtin/packages/hipblas/package.py index 84f51bff98..879da58cb2 100644 --- a/var/spack/repos/builtin/packages/hipblas/package.py +++ b/var/spack/repos/builtin/packages/hipblas/package.py @@ -64,6 +64,7 @@ class Hipblas(CMakePackage, CudaPackage, ROCmPackage): depends_on("googletest@1.10.0:", type="test") depends_on("netlib-lapack@3.7.1:", type="test") depends_on("boost@1.64.0:1.76.0 +program_options cxxstd=14", type="test") + depends_on("py-pyaml", type="test", when="@6.1:") patch("remove-hipblas-clients-file-installation.patch", when="@5.5:5.7.1") patch("remove-hipblas-clients-file-installation-6.0.patch", when="@6.0:") @@ -72,6 +73,7 @@ class Hipblas(CMakePackage, CudaPackage, ROCmPackage): depends_on("rocm-cmake@4.5.0:", type="build") for ver in ["6.0.0", "6.0.2", "6.1.0", "6.1.1", "6.1.2"]: depends_on(f"rocm-cmake@{ver}", when=f"+rocm @{ver}") + depends_on(f"rocm-openmp-extras@{ver}", type="test", when=f"+rocm @{ver}") depends_on("hip +cuda", when="+cuda") @@ -129,11 +131,13 @@ class Hipblas(CMakePackage, CudaPackage, ROCmPackage): args.append(self.define("BUILD_FILE_REORG_BACKWARD_COMPATIBILITY", True)) if self.spec.satisfies("@5.3.0:"): args.append("-DCMAKE_INSTALL_LIBDIR=lib") + if self.spec.satisfies("@6.1:") and self.run_tests: + args.append(self.define("LINK_BLIS", "OFF")) return args - @run_after("build") - @on_package_attributes(run_tests=True) - def check_build(self): - exe = Executable(join_path(self.build_directory, "clients", "staging", "hipblas-test")) + def check(self): + exe = Executable( + join_path(self.builder.build_directory, "clients", "staging", "hipblas-test") + ) exe("--gtest_filter=-*known_bug*") -- cgit v1.2.3-70-g09d2