From 70d3558596b96fe1dd0eef46deb325cc44b729dd Mon Sep 17 00:00:00 2001 From: Oliver Breitwieser Date: Thu, 14 Sep 2017 14:28:11 -0400 Subject: package: support verbosity when activating --- lib/spack/spack/package.py | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/lib/spack/spack/package.py b/lib/spack/spack/package.py index fb82aa201c..a9f348f04d 100644 --- a/lib/spack/spack/package.py +++ b/lib/spack/spack/package.py @@ -1773,7 +1773,7 @@ class PackageBase(with_metaclass(PackageMeta, object)): raise ActivationError("%s does not extend %s!" % (self.name, self.extendee.name)) - def do_activate(self, force=False): + def do_activate(self, force=False, verbose=True): """Called on an extension to invoke the extendee's activate method. Commands should call this routine, and should not call @@ -1788,14 +1788,17 @@ class PackageBase(with_metaclass(PackageMeta, object)): if not force: for spec in self.dependency_activations(): if not spec.package.is_activated(): - spec.package.do_activate(force=force) + spec.package.do_activate(force=force, verbose=verbose) self.extendee_spec.package.activate(self, **self.extendee_args) spack.store.layout.add_extension(self.extendee_spec, self.spec) - tty.msg( - "Activated extension %s for %s" % - (self.spec.short_spec, self.extendee_spec.cformat("$_$@$+$%@"))) + + if verbose: + tty.msg( + "Activated extension %s for %s" % + (self.spec.short_spec, + self.extendee_spec.cformat("$_$@$+$%@"))) def dependency_activations(self): return (spec for spec in self.spec.traverse(root=False, deptype='run') @@ -1826,6 +1829,7 @@ class PackageBase(with_metaclass(PackageMeta, object)): """Called on the extension to invoke extendee's deactivate() method.""" self._sanity_check_extension() force = kwargs.get('force', False) + verbose = kwargs.get("verbose", True) # Allow a force deactivate to happen. This can unlink # spurious files if something was corrupted. @@ -1853,9 +1857,11 @@ class PackageBase(with_metaclass(PackageMeta, object)): spack.store.layout.remove_extension( self.extendee_spec, self.spec) - tty.msg( - "Deactivated extension %s for %s" % - (self.spec.short_spec, self.extendee_spec.cformat("$_$@$+$%@"))) + if verbose: + tty.msg( + "Deactivated extension %s for %s" % + (self.spec.short_spec, + self.extendee_spec.cformat("$_$@$+$%@"))) def deactivate(self, extension, **kwargs): """Unlinks all files from extension out of this package's install dir. -- cgit v1.2.3-60-g2f50