From 7319516749358b7af4e71b26774d4ce03459a9df Mon Sep 17 00:00:00 2001 From: noguchi-k <55966120+noguchi-k@users.noreply.github.com> Date: Fri, 17 Jan 2020 03:14:52 +0900 Subject: falcon: Set Py_None to return value (#14532) --- var/spack/repos/builtin/packages/falcon/Py_None.patch | 10 ++++++++++ var/spack/repos/builtin/packages/falcon/package.py | 4 ++++ 2 files changed, 14 insertions(+) create mode 100644 var/spack/repos/builtin/packages/falcon/Py_None.patch diff --git a/var/spack/repos/builtin/packages/falcon/Py_None.patch b/var/spack/repos/builtin/packages/falcon/Py_None.patch new file mode 100644 index 0000000000..6f7ed073e7 --- /dev/null +++ b/var/spack/repos/builtin/packages/falcon/Py_None.patch @@ -0,0 +1,10 @@ +--- spack-src/src/c/ext_falcon.c.org 2020-01-15 17:40:41.279400137 +0900 ++++ spack-src/src/c/ext_falcon.c 2020-01-15 17:44:47.785718088 +0900 +@@ -9,5 +9,6 @@ + + m = Py_InitModule("ext_falcon", SpamMethods); + if (m == NULL) +- return; ++ Py_INCREF(Py_None); ++ return Py_None; + } diff --git a/var/spack/repos/builtin/packages/falcon/package.py b/var/spack/repos/builtin/packages/falcon/package.py index 558866ca13..36649dd7e6 100644 --- a/var/spack/repos/builtin/packages/falcon/package.py +++ b/var/spack/repos/builtin/packages/falcon/package.py @@ -28,3 +28,7 @@ class Falcon(PythonPackage): depends_on('pacbio-daligner', type='run') depends_on('pacbio-dextractor', type='run') depends_on('pacbio-damasker', type='run') + + # Python version 3 and later should return + # a value of PyObject type. [-Wreturn-type] + patch('Py_None.patch', when='^python@3:') -- cgit v1.2.3-70-g09d2