From 7405d18e988efb24543ed921a44213f02940770f Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Tue, 12 Jul 2022 16:12:43 +0200 Subject: environment.py: only acquire write lock when necessary (#31493) --- lib/spack/spack/environment/environment.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/spack/spack/environment/environment.py b/lib/spack/spack/environment/environment.py index 7366468f7a..1c16c708b3 100644 --- a/lib/spack/spack/environment/environment.py +++ b/lib/spack/spack/environment/environment.py @@ -1612,9 +1612,10 @@ class Environment(object): # ensure specs already installed are marked explicit all_specs = specs or [cs for _, cs in self.concretized_specs()] specs_installed = [s for s in all_specs if s.installed] - with spack.store.db.write_transaction(): # do all in one transaction - for spec in specs_installed: - spack.store.db.update_explicit(spec, True) + if specs_installed: + with spack.store.db.write_transaction(): # do all in one transaction + for spec in specs_installed: + spack.store.db.update_explicit(spec, True) if not specs_to_install: tty.msg('All of the packages are already installed') -- cgit v1.2.3-70-g09d2