From a520a7ef284ca7788f1c26d0bb26ea901a2080a7 Mon Sep 17 00:00:00 2001 From: Sergey Kosukhin Date: Thu, 6 Oct 2022 20:15:28 +0200 Subject: tcl module template: automatically unload automatically loaded modules (#32853) Remove `module-info mode load` condition that prevents auto-unloading when autoloading is enabled. It looks like this condition was added to work around an issue in environment-modules that is no longer necessary. Add quotes to make is-loaded happy --- lib/spack/spack/test/modules/tcl.py | 2 +- share/spack/templates/modules/modulefile.tcl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/spack/spack/test/modules/tcl.py b/lib/spack/spack/test/modules/tcl.py index 769bcf50a7..0d30e19958 100644 --- a/lib/spack/spack/test/modules/tcl.py +++ b/lib/spack/spack/test/modules/tcl.py @@ -113,7 +113,7 @@ class TestTcl(object): assert len([x for x in content if x.startswith("prepend-path CMAKE_PREFIX_PATH")]) == 0 assert len([x for x in content if 'setenv FOO "foo"' in x]) == 0 assert len([x for x in content if "unsetenv BAR" in x]) == 0 - assert len([x for x in content if "is-loaded foo/bar" in x]) == 1 + assert len([x for x in content if "is-loaded 'foo/bar'" in x]) == 1 assert len([x for x in content if "module load foo/bar" in x]) == 1 assert len([x for x in content if "setenv LIBDWARF_ROOT" in x]) == 1 diff --git a/share/spack/templates/modules/modulefile.tcl b/share/spack/templates/modules/modulefile.tcl index 21dacfedc0..0c11f7c106 100644 --- a/share/spack/templates/modules/modulefile.tcl +++ b/share/spack/templates/modules/modulefile.tcl @@ -23,7 +23,7 @@ proc ModulesHelp { } { {% block autoloads %} {% for module in autoload %} -if {{ '{' }} [ module-info mode load ] && ![ is-loaded {{ module }} ] {{ '}' }} {{ '{' }} +if {{ '{' }} ![ is-loaded '{{ module }}' ] {{ '}' }} {{ '{' }} {% if verbose %} puts stderr "Autoloading {{ module }}" {% endif %} -- cgit v1.2.3-70-g09d2