From a947680e371eee33744c0568be2125d604d8365c Mon Sep 17 00:00:00 2001
From: bernhardkaindl <43588962+bernhardkaindl@users.noreply.github.com>
Date: Sun, 26 Sep 2021 10:32:04 +0200
Subject: dropwatch: make check starts a daemon which does not stop: Skip it
 (#26164)

dropwatch is a network packet drop checker and it's make check starts
a daemon which does not terminate.

- Skip this test to not block builds.
- Add depends_on('pkgconfig', type='build')
  It is needed in case the host does not have pkg-config installed.
- Remove the depends_on('m4', type='build'):
  The depends_on('autoconf', type='build') pulls m4 as it needs it.
---
 var/spack/repos/builtin/packages/dropwatch/package.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/var/spack/repos/builtin/packages/dropwatch/package.py b/var/spack/repos/builtin/packages/dropwatch/package.py
index 873797d561..d0b69ccacd 100644
--- a/var/spack/repos/builtin/packages/dropwatch/package.py
+++ b/var/spack/repos/builtin/packages/dropwatch/package.py
@@ -20,7 +20,7 @@ class Dropwatch(AutotoolsPackage):
     depends_on('autoconf', type='build')
     depends_on('automake', type='build')
     depends_on('libtool',  type='build')
-    depends_on('m4',       type='build')
+    depends_on('pkgconfig', type='build')
     depends_on('libnl')
     depends_on('libpcap')
     depends_on('binutils')
@@ -29,3 +29,7 @@ class Dropwatch(AutotoolsPackage):
     def autoreconf(self, spec, prefix):
         bash = which('bash')
         bash('./autogen.sh')
+
+    def check(self):
+        """`make check` starts a daemon which does not terminate, blocking the builds"""
+        pass
-- 
cgit v1.2.3-70-g09d2