From b1559cc831620ee2b2cf8e57fdecc5bb3bf8edfd Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Fri, 21 Oct 2022 14:42:06 +0200 Subject: gitlab: when_possible -> false (#33443) `reuse` and `when_possible` concretization broke the invariant that `spec[pkg_name]` has unique keys. This invariant is relied on in tons of places, such as when setting up the build environment. When using `when_possible` concretization, one may end up with two or more `perl`s or `python`s among the transitive deps of a spec, because concretization does not consider build-only deps of reusable specs. Until the code base is fixed not to rely on this broken property of `__getitem__`, we should disable reuse in CI. --- share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml | 2 +- share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml b/share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml index eb60dd85fe..4808763f37 100644 --- a/share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml +++ b/share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml @@ -3,7 +3,7 @@ spack: concretizer: reuse: false - unify: when_possible + unify: false config: install_tree: diff --git a/share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml b/share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml index ce8441a5d8..944c110ac5 100644 --- a/share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml +++ b/share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml @@ -3,7 +3,7 @@ spack: concretizer: reuse: false - unify: when_possible + unify: false config: concretizer: clingo -- cgit v1.2.3-70-g09d2