From b1f5b5f75bf0cf9ecb1b05eb0670ee6dd0143e01 Mon Sep 17 00:00:00 2001 From: George Hartzell Date: Tue, 7 Feb 2017 18:22:30 -0800 Subject: Add comment explaining why patch is still needed (#3054) [The fix](https://github.com/golang/go/issues/17986) for the small buglet addressed by `misc-cgo-testcshared.patch` has been merged into the tree a while back. I was surprised to see that it wasn't in 1.7.5 and did a bit of digging. It is *has not* been merged into the 1.7 branch but it *has* been merged into 1.8 (and therefor the patch will no longer be necessary). Figured I'd document my digging for the next person to come along. --- var/spack/repos/builtin/packages/go/package.py | 1 + 1 file changed, 1 insertion(+) diff --git a/var/spack/repos/builtin/packages/go/package.py b/var/spack/repos/builtin/packages/go/package.py index d0fb40096b..8d7596eee4 100644 --- a/var/spack/repos/builtin/packages/go/package.py +++ b/var/spack/repos/builtin/packages/go/package.py @@ -73,6 +73,7 @@ class Go(Package): patch('time_test.patch', when='@1.6.4:1.7.4') # https://github.com/golang/go/issues/17986 + # The fix for this issue has been merged into the 1.8 tree. patch('misc-cgo-testcshared.patch', level=0, when='@1.6.4:1.7.5') # NOTE: Older versions of Go attempt to download external files that have -- cgit v1.2.3-70-g09d2