From bb6ec7fb40c14b37e094a860e3625af53f633174 Mon Sep 17 00:00:00 2001 From: Sinan Date: Mon, 12 Aug 2019 13:45:05 -0700 Subject: Package/grass: fix iconv linking issue (#12165) * fix iconv linking issue, package_grass fix linking iconv, add more comments --- var/spack/repos/builtin/packages/grass/package.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/var/spack/repos/builtin/packages/grass/package.py b/var/spack/repos/builtin/packages/grass/package.py index 184c1eba88..1c42d45069 100644 --- a/var/spack/repos/builtin/packages/grass/package.py +++ b/var/spack/repos/builtin/packages/grass/package.py @@ -195,3 +195,12 @@ class Grass(AutotoolsPackage): args.append('--without-geos') return args + + # see issue: https://github.com/spack/spack/issues/11325 + # 'Platform.make' is created after configure step + # hence invoke the following function afterwards + @run_after('configure') + def fix_iconv_linking(self): + makefile = FileFilter('include/Make/Platform.make') + makefile.filter(r'^ICONVLIB\s*=\s*', 'ICONVLIB = -liconv') + return None -- cgit v1.2.3-70-g09d2