From d579231967d502b56b6254c660e6dfddc4f2ba3a Mon Sep 17 00:00:00 2001 From: Denis Davydov Date: Thu, 17 May 2018 22:58:29 +0200 Subject: flex: use 2.6.3. by default (#8154) Fixes #8152 Flex 2.6.4 doesn't build with gcc@7:. This sets Flex 2.6.3 as the preferred version. The flex package had a conflict directive for this but originally the recorded conflict was specific to ubuntu; this appears to be an issue on multiple operating systems so this also updates the conflict to be more general and adds a comment which links to the relevant issues. --- var/spack/repos/builtin/packages/flex/package.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/var/spack/repos/builtin/packages/flex/package.py b/var/spack/repos/builtin/packages/flex/package.py index 01545fc9f4..b847de22d0 100644 --- a/var/spack/repos/builtin/packages/flex/package.py +++ b/var/spack/repos/builtin/packages/flex/package.py @@ -33,7 +33,10 @@ class Flex(AutotoolsPackage): url = "https://github.com/westes/flex/releases/download/v2.6.1/flex-2.6.1.tar.gz" version('2.6.4', '2882e3179748cc9f9c23ec593d6adc8d') - version('2.6.3', 'a5f65570cd9107ec8a8ec88f17b31bb1') + # 2.6.4 fails to compile with gcc@7.2: + # see https://github.com/spack/spack/issues/8152 and + # https://github.com/spack/spack/issues/6942 + version('2.6.3', 'a5f65570cd9107ec8a8ec88f17b31bb1', preferred=True) # Avoid flex '2.6.2' (major bug) # See issue #2554; https://github.com/westes/flex/issues/113 version('2.6.1', '05bcd8fb629e0ae130311e8a6106fa82') @@ -53,9 +56,9 @@ class Flex(AutotoolsPackage): depends_on('automake', type='build', when='@:2.6.0') depends_on('libtool', type='build', when='@:2.6.0') - # Build issue for v2.6.4 when gcc 7.2.0 is used on Ubuntu 17.10. + # Build issue for v2.6.4 when gcc@7.2.0: is used # See issue #219; https://github.com/westes/flex/issues/219 - conflicts('%gcc@7.2.0: os=ubuntu17.10', when='@2.6.4') + conflicts('%gcc@7.2.0:', when='@2.6.4') def url_for_version(self, version): url = "https://github.com/westes/flex" -- cgit v1.2.3-70-g09d2