From d6555f64b0e352cf42709d46e5e9a8201a9966e8 Mon Sep 17 00:00:00 2001 From: "Adam J. Stewart" Date: Mon, 23 Sep 2019 17:25:33 -0500 Subject: Fix detection of Apple Clang 11.0.0 (#12912) --- lib/spack/spack/compilers/clang.py | 2 +- lib/spack/spack/test/compilers.py | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/spack/spack/compilers/clang.py b/lib/spack/spack/compilers/clang.py index 209759e7be..ea4ddaf401 100644 --- a/lib/spack/spack/compilers/clang.py +++ b/lib/spack/spack/compilers/clang.py @@ -205,7 +205,7 @@ class Clang(Compiler): ver = 'unknown' match = re.search( # Apple's LLVM compiler has its own versions, so suffix them. - r'^Apple LLVM version ([^ )]+)|' + r'^Apple (?:LLVM|clang) version ([^ )]+)|' # Normal clang compiler versions are left as-is r'clang version ([^ )]+)-svn[~.\w\d-]*|' r'clang version ([^ )]+)-[~.\w\d-]*|' diff --git a/lib/spack/spack/test/compilers.py b/lib/spack/spack/test/compilers.py index 171d390de6..dc104225f1 100644 --- a/lib/spack/spack/test/compilers.py +++ b/lib/spack/spack/test/compilers.py @@ -329,6 +329,11 @@ def test_fj_flags(): @pytest.mark.regression('10191') @pytest.mark.parametrize('version_str,expected_version', [ # macOS clang + ('Apple clang version 11.0.0 (clang-1100.0.33.8)\n' + 'Target: x86_64-apple-darwin18.7.0\n' + 'Thread model: posix\n' + 'InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin\n', # noqa + '11.0.0-apple'), ('Apple LLVM version 7.0.2 (clang-700.1.81)\n' 'Target: x86_64-apple-darwin15.2.0\n' 'Thread model: posix\n', '7.0.2-apple'), -- cgit v1.2.3-70-g09d2