From d8cbd37aaadf6c375ac071017d8af46221e421e0 Mon Sep 17 00:00:00 2001 From: "Seth R. Johnson" Date: Sat, 22 May 2021 14:47:43 -0400 Subject: Fix makefile filter suggestions (#23856) Bash has a builtin `fc` that will override the compiler if you use "fc", so it's better to use the full spack-supplied compiler path. Additionally, the filter regex in the docs was wrong: it replaced the entire assignment operation with the RHS. --- lib/spack/docs/build_systems/makefilepackage.rst | 6 ++++-- lib/spack/docs/packaging_guide.rst | 8 ++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/spack/docs/build_systems/makefilepackage.rst b/lib/spack/docs/build_systems/makefilepackage.rst index f425855b69..e78c558a5a 100644 --- a/lib/spack/docs/build_systems/makefilepackage.rst +++ b/lib/spack/docs/build_systems/makefilepackage.rst @@ -147,8 +147,10 @@ and a ``filter_file`` method to help with this. For example: def edit(self, spec, prefix): makefile = FileFilter('Makefile') - makefile.filter('CC = gcc', 'CC = cc') - makefile.filter('CXX = g++', 'CC = c++') + makefile.filter(r'^\s*CC\s*=.*', 'CC = ' + spack_cc) + makefile.filter(r'^\s*CXX\s*=.*', 'CXX = ' + spack_cxx) + makefile.filter(r'^\s*F77\s*=.*', 'F77 = ' + spack_f77) + makefile.filter(r'^\s*FC\s*=.*', 'FC = ' + spack_fc) `stream `_ diff --git a/lib/spack/docs/packaging_guide.rst b/lib/spack/docs/packaging_guide.rst index 24666fc44a..5d00a64fac 100644 --- a/lib/spack/docs/packaging_guide.rst +++ b/lib/spack/docs/packaging_guide.rst @@ -4800,10 +4800,10 @@ Filtering functions .. code-block:: python - filter_file(r'^CC\s*=.*', spack_cc, 'Makefile') - filter_file(r'^CXX\s*=.*', spack_cxx, 'Makefile') - filter_file(r'^F77\s*=.*', spack_f77, 'Makefile') - filter_file(r'^FC\s*=.*', spack_fc, 'Makefile') + filter_file(r'^\s*CC\s*=.*', 'CC = ' + spack_cc, 'Makefile') + filter_file(r'^\s*CXX\s*=.*', 'CXX = ' + spack_cxx, 'Makefile') + filter_file(r'^\s*F77\s*=.*', 'F77 = ' + spack_f77, 'Makefile') + filter_file(r'^\s*FC\s*=.*', 'FC = ' + spack_fc, 'Makefile') #. Replacing ``#!/usr/bin/perl`` with ``#!/usr/bin/env perl`` in ``bib2xhtml``: -- cgit v1.2.3-60-g2f50