From dd15c37021d9d8908d913b63c764fd7927f16ff4 Mon Sep 17 00:00:00 2001 From: afzpatel <122491982+afzpatel@users.noreply.github.com> Date: Fri, 17 Mar 2023 05:56:54 -0400 Subject: hipcub and rocprim: enable testing (#35660) --- var/spack/repos/builtin/packages/hipcub/package.py | 3 ++- var/spack/repos/builtin/packages/rocprim/package.py | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/var/spack/repos/builtin/packages/hipcub/package.py b/var/spack/repos/builtin/packages/hipcub/package.py index eb038dc5bd..0c946897e0 100644 --- a/var/spack/repos/builtin/packages/hipcub/package.py +++ b/var/spack/repos/builtin/packages/hipcub/package.py @@ -106,6 +106,7 @@ class Hipcub(CMakePackage): depends_on("cmake@3.10.2:", type="build", when="@4.2.0:") depends_on("cmake@3.5.1:", type="build") depends_on("numactl", type="link", when="@3.7.0:") + depends_on("googletest@1.10.0:", type="test") for ver in [ "3.5.0", @@ -140,7 +141,7 @@ class Hipcub(CMakePackage): env.set("CXX", self.spec["hip"].hipcc) def cmake_args(self): - args = [] + args = [self.define("BUILD_TEST", self.run_tests)] if self.spec.satisfies("^cmake@3.21.0:3.21.2"): args.append(self.define("__skip_rocmclang", "ON")) diff --git a/var/spack/repos/builtin/packages/rocprim/package.py b/var/spack/repos/builtin/packages/rocprim/package.py index 9f3caf66d5..16a99d5ff7 100644 --- a/var/spack/repos/builtin/packages/rocprim/package.py +++ b/var/spack/repos/builtin/packages/rocprim/package.py @@ -109,6 +109,7 @@ class Rocprim(CMakePackage): depends_on("cmake@3.10.2:", type="build", when="@4.2.0:") depends_on("cmake@3.5.1:", type="build") depends_on("numactl", type="link", when="@3.7.0:") + depends_on("googletest@1.10.0:", type="test") for ver in [ "3.5.0", @@ -149,8 +150,8 @@ class Rocprim(CMakePackage): def cmake_args(self): args = [ - self.define("ONLY_INSTALL", "ON"), - self.define("BUILD_TEST", "OFF"), + self.define("ONLY_INSTALL", (not self.run_tests)), + self.define("BUILD_TEST", self.run_tests), self.define("BUILD_BENCHMARK", "OFF"), self.define("BUILD_EXAMPLE", "OFF"), ] -- cgit v1.2.3-60-g2f50