From fbf50fbfa856cbf67855320971738647257eb897 Mon Sep 17 00:00:00 2001 From: Gianluca Ficarelli <26835404+GianlucaFicarelli@users.noreply.github.com> Date: Mon, 4 Apr 2022 11:40:09 +0200 Subject: Remove "dir=/tmp" when using tempfile.mkdtemp in packages (#29866) From the tempfile module docs: The default directory is chosen from a platform-dependent list, but the user of the application can control the directory location by setting the TMPDIR, TEMP or TMP environment variables --- var/spack/repos/builtin/packages/nix/package.py | 6 +++--- var/spack/repos/builtin/packages/py-dm-tree/package.py | 2 +- var/spack/repos/builtin/packages/py-keras/package.py | 2 +- var/spack/repos/builtin/packages/py-tensorboard/package.py | 2 +- var/spack/repos/builtin/packages/py-tensorflow-estimator/package.py | 2 +- .../repos/builtin/packages/py-tensorflow-probability/package.py | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/var/spack/repos/builtin/packages/nix/package.py b/var/spack/repos/builtin/packages/nix/package.py index 60e41873ed..6b8fbabc0f 100644 --- a/var/spack/repos/builtin/packages/nix/package.py +++ b/var/spack/repos/builtin/packages/nix/package.py @@ -87,9 +87,9 @@ class Nix(AutotoolsPackage): def installcheck(self): # We have to clean this tmpdir ourself later as it contains readonly directories - self.test_path = tempfile.mkdtemp(dir='/tmp', - prefix='tmp-spack-check-nix-{0}-'. - format(self.spec.version)) + self.test_path = tempfile.mkdtemp( + prefix='tmp-spack-check-nix-{0}-'.format(self.spec.version) + ) mkdir(self.test_path + '/nix-test') mkdir(self.test_path + '/tests') os.environ['TMPDIR'] = self.test_path diff --git a/var/spack/repos/builtin/packages/py-dm-tree/package.py b/var/spack/repos/builtin/packages/py-dm-tree/package.py index 33efb4e2ce..18b16abd06 100644 --- a/var/spack/repos/builtin/packages/py-dm-tree/package.py +++ b/var/spack/repos/builtin/packages/py-dm-tree/package.py @@ -28,7 +28,7 @@ class PyDmTree(PythonPackage): remove_linked_tree(self.tmp_path) def patch(self): - self.tmp_path = tempfile.mkdtemp(dir='/tmp', prefix='spack') + self.tmp_path = tempfile.mkdtemp(prefix='spack') env['TEST_TMPDIR'] = self.tmp_path env['HOME'] = self.tmp_path args = [ diff --git a/var/spack/repos/builtin/packages/py-keras/package.py b/var/spack/repos/builtin/packages/py-keras/package.py index 81c9d3c9e5..3671053433 100644 --- a/var/spack/repos/builtin/packages/py-keras/package.py +++ b/var/spack/repos/builtin/packages/py-keras/package.py @@ -84,7 +84,7 @@ class PyKeras(PythonPackage): @when('@2.5.0:') def install(self, spec, prefix): - self.tmp_path = tempfile.mkdtemp(dir='/tmp', prefix='spack') + self.tmp_path = tempfile.mkdtemp(prefix='spack') env['HOME'] = self.tmp_path args = [ diff --git a/var/spack/repos/builtin/packages/py-tensorboard/package.py b/var/spack/repos/builtin/packages/py-tensorboard/package.py index e761016d49..5cbffad13e 100644 --- a/var/spack/repos/builtin/packages/py-tensorboard/package.py +++ b/var/spack/repos/builtin/packages/py-tensorboard/package.py @@ -71,7 +71,7 @@ class PyTensorboard(Package): '.bazelrc') def setup_build_environment(self, env): - self.tmp_path = tempfile.mkdtemp(dir='/tmp', prefix='spack') + self.tmp_path = tempfile.mkdtemp(prefix='spack') env.set('TEST_TMPDIR', self.tmp_path) def configure(self, spec, prefix): diff --git a/var/spack/repos/builtin/packages/py-tensorflow-estimator/package.py b/var/spack/repos/builtin/packages/py-tensorflow-estimator/package.py index 51ef4c42f4..88c321cbba 100644 --- a/var/spack/repos/builtin/packages/py-tensorflow-estimator/package.py +++ b/var/spack/repos/builtin/packages/py-tensorflow-estimator/package.py @@ -47,7 +47,7 @@ class PyTensorflowEstimator(Package): depends_on('py-funcsigs@1.0.2:', type=('build', 'run'), when='^python@:3.2') def install(self, spec, prefix): - self.tmp_path = tempfile.mkdtemp(dir='/tmp', prefix='spack') + self.tmp_path = tempfile.mkdtemp(prefix='spack') env['TEST_TMPDIR'] = self.tmp_path env['HOME'] = self.tmp_path diff --git a/var/spack/repos/builtin/packages/py-tensorflow-probability/package.py b/var/spack/repos/builtin/packages/py-tensorflow-probability/package.py index cd0b7d281f..0c7db4ed7b 100644 --- a/var/spack/repos/builtin/packages/py-tensorflow-probability/package.py +++ b/var/spack/repos/builtin/packages/py-tensorflow-probability/package.py @@ -44,7 +44,7 @@ class PyTensorflowProbability(Package): depends_on('bazel@3.2.0:', type='build') def install(self, spec, prefix): - self.tmp_path = tempfile.mkdtemp(dir='/tmp', prefix='spack') + self.tmp_path = tempfile.mkdtemp(prefix='spack') env['TEST_TMPDIR'] = self.tmp_path env['HOME'] = self.tmp_path -- cgit v1.2.3-70-g09d2