From 005b22aa8b8a68a5d0afe3fc3d06f8e1d85b35da Mon Sep 17 00:00:00 2001 From: Massimiliano Culpo Date: Sat, 26 Aug 2017 05:40:37 +0200 Subject: Removed default value for 'dirty' function argument. (#5109) This change is done to avoid inconsistencies during refactoring. The rationale is that functions at different levels in the call stack all define a default for the 'dirty' argument. This PR removes the default value for all the functions except the top-level one (`PackageBase.do_install`). In this way not defining 'dirty' will result in an error, instead of the default value being used. This will reduce the risk of having an inconsistent behavior after a refactoring. --- lib/spack/spack/build_environment.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lib') diff --git a/lib/spack/spack/build_environment.py b/lib/spack/spack/build_environment.py index 7bef1d3789..a27d8c68ab 100644 --- a/lib/spack/spack/build_environment.py +++ b/lib/spack/spack/build_environment.py @@ -178,7 +178,7 @@ def set_compiler_environment_variables(pkg, env): return env -def set_build_environment_variables(pkg, env, dirty=False): +def set_build_environment_variables(pkg, env, dirty): """Ensure a clean install environment when we build packages. This involves unsetting pesky environment variables that may @@ -450,7 +450,7 @@ def load_external_modules(pkg): load_module(dep.external_module) -def setup_package(pkg, dirty=False): +def setup_package(pkg, dirty): """Execute all environment setup routines.""" spack_env = EnvironmentModifications() run_env = EnvironmentModifications() @@ -516,7 +516,7 @@ def setup_package(pkg, dirty=False): spack_env.apply_modifications() -def fork(pkg, function, dirty=False): +def fork(pkg, function, dirty): """Fork a child process to do part of a spack build. Args: -- cgit v1.2.3-70-g09d2