From 263007ba81ac3164531de7bab8c8e3e20895cf26 Mon Sep 17 00:00:00 2001 From: Massimiliano Culpo Date: Fri, 12 Apr 2024 09:31:44 +0200 Subject: solver: add an integrity constraint for virtual nodes (#43582) Upon close inspection of clingo answer sets, in some cases we have "equivalent" (i.e. same hash for the concrete spec) duplicates that differ only because of virtual nodes that are added to the answer set, without any edge using them. --- lib/spack/spack/solver/concretize.lp | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'lib') diff --git a/lib/spack/spack/solver/concretize.lp b/lib/spack/spack/solver/concretize.lp index 4a2edaa067..5f8163c61b 100644 --- a/lib/spack/spack/solver/concretize.lp +++ b/lib/spack/spack/solver/concretize.lp @@ -523,6 +523,12 @@ attr("virtual_on_edge", PackageNode, ProviderNode, Virtual) provider(ProviderNode, node(_, Virtual)), not external(PackageNode). +% If a virtual node is in the answer set, it must be either a virtual root, +% or used somewhere +:- attr("virtual_node", node(_, Virtual)), + not attr("virtual_on_incoming_edges", _, Virtual), + not attr("virtual_root", node(_, Virtual)). + attr("virtual_on_incoming_edges", ProviderNode, Virtual) :- attr("virtual_on_edge", _, ProviderNode, Virtual). -- cgit v1.2.3-70-g09d2