From 26552533be04e83e66be2c28e0eb5011cb54e8fa Mon Sep 17 00:00:00 2001 From: Peter Scheibel Date: Sat, 19 Mar 2022 21:37:40 -0700 Subject: We were doing a check in a metaclass to ensure that Package classes weren't defining a function themselves; this check failed (erroneously) if that Package class subclassed another package class (because the check examined all superclasses and thought the definition we automatically add was an offender) (#29569) --- lib/spack/spack/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/spack/spack/package.py b/lib/spack/spack/package.py index f1c7a824e6..de903c4ffa 100644 --- a/lib/spack/spack/package.py +++ b/lib/spack/spack/package.py @@ -288,7 +288,7 @@ class DetectablePackageMeta(object): # This function should not be overridden by subclasses, # as it is not designed for bespoke pkg detection but rather # on a per-platform basis - if hasattr(cls, 'platform_executables'): + if 'platform_executables' in cls.__dict__.keys(): raise PackageError("Packages should not override platform_executables") cls.platform_executables = platform_executables -- cgit v1.2.3-60-g2f50