From 3301e21f06b918321e7471f8aaed997ee453f5b1 Mon Sep 17 00:00:00 2001 From: cedricchevalier19 Date: Tue, 7 Aug 2018 18:13:07 +0200 Subject: Fix performance issue when compiling. (#8828) * Fix performance issue when compiling. Spack was doing active wait when compiling, spoiling one core. My fix consists in not setting any timeout for select, instead of the previous 0 second. * Fix comments about select.select timeout --- lib/spack/llnl/util/tty/log.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/spack/llnl/util/tty/log.py b/lib/spack/llnl/util/tty/log.py index 70dc7c4ee5..64238f3ba0 100644 --- a/lib/spack/llnl/util/tty/log.py +++ b/lib/spack/llnl/util/tty/log.py @@ -446,10 +446,9 @@ class log_output(object): try: with keyboard_input(stdin): while True: - # Without the last parameter (timeout) select will - # wait until at least one of the two streams are - # ready. This may cause the function to hang. - rlist, _, xlist = select.select(istreams, [], [], 0) + # No need to set any timeout for select.select + # Wait until a key press or an event on in_pipe. + rlist, _, _ = select.select(istreams, [], []) # Allow user to toggle echo with 'v' key. # Currently ignores other chars. -- cgit v1.2.3-60-g2f50