From 56fd9bc7b68e7ad224d1b0006bcbe8a3705be082 Mon Sep 17 00:00:00 2001 From: Geoffrey M Oxberry Date: Thu, 8 Aug 2019 15:11:11 -0700 Subject: AutotoolsPackage: remove redundant libtoolize call This commit removes redundant calls to `libtoolize` and `aclocal`. Some configurations, such as a Spack user using macOS with a Homebrew-installed `libtool` added to their `packages.yaml`, have `autoreconf` and GNU libtoolize installed as `glibtoolize`, but not `libtoolize`. While Spack installations of `libtool` built from source would install `glibtoolize` and symlink `libtoolize` to `glibtoolize`, an external installation of GNU libtoolize as `glibtoolize` will not have such a symlink, and thus the call `m.libtoolize()` will throw an error because `libtoolize` does not exist at the path referenced by `m.libtoolize()` (i.e., `self.spec['libtool'].prefix.bin.join('libtoolize')). However, on these same systems, `autoreconf` runs correctly, and calls `glibtoolize` instead of `libtoolize`, when appropriate. Thus, removing the call to `libtoolize` should resolve the error mentioned above. The redundant call to `aclocal` is also removed in this commit because the maintainers of GNU Automake state that "`aclocal` is expected to disappear" and suggest that downstream users never call `aclocal` directly -- rather, they suggest calling `autoreconf` instead. --- lib/spack/spack/build_systems/autotools.py | 4 ---- 1 file changed, 4 deletions(-) (limited to 'lib') diff --git a/lib/spack/spack/build_systems/autotools.py b/lib/spack/spack/build_systems/autotools.py index cd6cfd94bd..b8fb6dc0b9 100644 --- a/lib/spack/spack/build_systems/autotools.py +++ b/lib/spack/spack/build_systems/autotools.py @@ -191,10 +191,6 @@ class AutotoolsPackage(PackageBase): tty.warn('*********************************************************') with working_dir(self.configure_directory): m = inspect.getmodule(self) - # This part should be redundant in principle, but - # won't hurt - m.libtoolize() - m.aclocal() # This line is what is needed most of the time # --install, --verbose, --force autoreconf_args = ['-ivf'] -- cgit v1.2.3-60-g2f50