From 5daf023aecf3d72943cff0a010dfafd95edfdf3b Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Tue, 21 Dec 2021 18:41:12 +0100 Subject: Regenerate views when specs already installed (#28113) With this commit: ``` $ spack env activate --temp $ spack install zlib ==> All of the packages are already installed ==> Updating view at /tmp/spack-faiirgmt/.spack-env/view $ spack install zlib ==> All of the packages are already installed ``` Before this PR: ``` $ spack env activate --temp $ spack install zlib ==> All of the packages are already installed $ spack install zlib ==> All of the packages are already installed ``` No view was generated --- lib/spack/spack/environment/environment.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/spack/spack/environment/environment.py b/lib/spack/spack/environment/environment.py index a6be5d1c50..3114f55638 100644 --- a/lib/spack/spack/environment/environment.py +++ b/lib/spack/spack/environment/environment.py @@ -1500,10 +1500,8 @@ class Environment(object): if not specs_to_install: tty.msg('All of the packages are already installed') - return - - tty.debug('Processing {0} uninstalled specs'.format( - len(specs_to_install))) + else: + tty.debug('Processing {0} uninstalled specs'.format(len(specs_to_install))) install_args['overwrite'] = install_args.get( 'overwrite', []) + self._get_overwrite_specs() -- cgit v1.2.3-70-g09d2