From a260e7e860aab97ec8e2ece1b6586504857ff27b Mon Sep 17 00:00:00 2001 From: Jeffrey Salmond Date: Sat, 5 Nov 2016 06:20:49 +0000 Subject: Bugfix in concretize_compiler (#2196) * fix bug in search for concrete compiler * simplify implementation of concretize_compiler * fix flake8 errors --- lib/spack/spack/concretize.py | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) (limited to 'lib') diff --git a/lib/spack/spack/concretize.py b/lib/spack/spack/concretize.py index 2351e2bfc9..2d5b66487e 100644 --- a/lib/spack/spack/concretize.py +++ b/lib/spack/spack/concretize.py @@ -385,14 +385,13 @@ class DefaultConcretizer(object): arch.platform_os) # copy concrete version into other_compiler - index = 0 - while not _proper_compiler_style(matches[index], spec.architecture): - index += 1 - if index == len(matches) - 1: - arch = spec.architecture - raise UnavailableCompilerVersionError(spec.compiler, - arch.platform_os) - spec.compiler = matches[index].copy() + try: + spec.compiler = next( + c for c in matches + if _proper_compiler_style(c, spec.architecture)).copy() + except StopIteration: + raise UnavailableCompilerVersionError(spec.compiler, + arch.platform_os) assert(spec.compiler.concrete) return True # things changed. -- cgit v1.2.3-60-g2f50