From b6b44948b8624b6e23484a8cb59f8e325ef76e37 Mon Sep 17 00:00:00 2001 From: Nathan <35582439+yee29@users.noreply.github.com> Date: Wed, 29 Apr 2020 08:52:23 -0700 Subject: prefix gets removed when adding additional configure options (#16335) * prefix gets removed when adding additional configure options * Update waf documentation to reflect the new change --- lib/spack/docs/build_systems/wafpackage.rst | 5 +++-- lib/spack/spack/build_systems/waf.py | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/spack/docs/build_systems/wafpackage.rst b/lib/spack/docs/build_systems/wafpackage.rst index 1916630f4c..36fc21a772 100644 --- a/lib/spack/docs/build_systems/wafpackage.rst +++ b/lib/spack/docs/build_systems/wafpackage.rst @@ -47,8 +47,9 @@ Each phase provides a ```` function that runs: where ```` is the number of parallel jobs to build with. Each phase also has a ```` function that can pass arguments to this call. -All of these functions are empty except for the ``configure_args`` -function, which passes ``--prefix=/path/to/installation/prefix``. +All of these functions are empty. The ``configure`` phase +automatically adds ``--prefix=/path/to/installation/prefix``, so you +don't need to add that in the ``configure_args``. ^^^^^^^ Testing diff --git a/lib/spack/spack/build_systems/waf.py b/lib/spack/spack/build_systems/waf.py index 6bf9a432e0..a1581660f2 100644 --- a/lib/spack/spack/build_systems/waf.py +++ b/lib/spack/spack/build_systems/waf.py @@ -75,13 +75,14 @@ class WafPackage(PackageBase): def configure(self, spec, prefix): """Configures the project.""" - args = self.configure_args() + args = ['--prefix={0}'.format(self.prefix)] + args += self.configure_args() self.waf('configure', *args) def configure_args(self): """Arguments to pass to configure.""" - return ['--prefix={0}'.format(self.prefix)] + return [] def build(self, spec, prefix): """Executes the build.""" -- cgit v1.2.3-70-g09d2