From fb849a4b7f1361fe276e0761b6fdd73195ea1600 Mon Sep 17 00:00:00 2001 From: Satish Balay Date: Wed, 31 Oct 2018 14:49:04 -0500 Subject: static_to_shared_library: separate options from option values (#9690) The 'static_to_shared_library' function takes a compiler Executable, which is intended to be invoked with a list of arguments; the arguments must be separated from their values in the list, given the way that 'Executable.__call__' invokes the underlying executable. 'static_to_shared_library' was not doing this, which this commit fixes. --- lib/spack/spack/build_environment.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/spack/spack/build_environment.py b/lib/spack/spack/build_environment.py index fa79683717..3476df89d9 100644 --- a/lib/spack/spack/build_environment.py +++ b/lib/spack/spack/build_environment.py @@ -497,16 +497,16 @@ def _static_to_shared_library(arch, compiler, static_lib, shared_lib=None, compiler_args = [ '-dynamiclib', - '-install_name {0}'.format(install_name), + '-install_name', '{0}'.format(install_name), '-Wl,-force_load,{0}'.format(static_lib) ] if compat_version: - compiler_args.append('-compatibility_version {0}'.format( - compat_version)) + compiler_args.extend(['-compatibility_version', '{0}'.format( + compat_version)]) if version: - compiler_args.append('-current_version {0}'.format(version)) + compiler_args.extend(['-current_version', '{0}'.format(version)]) if len(arguments) > 0: compiler_args.extend(arguments) -- cgit v1.2.3-70-g09d2