From fc96f62794a5c718afb5904d93bb9370ed4a261d Mon Sep 17 00:00:00 2001 From: Peter Scheibel Date: Wed, 25 Nov 2015 18:08:17 -0800 Subject: Updated documentation/naming in tally_plugin to reflect that the count of the total number of tests run excludes skipped tests --- lib/spack/spack/test/__init__.py | 2 +- lib/spack/spack/test/tally_plugin.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'lib') diff --git a/lib/spack/spack/test/__init__.py b/lib/spack/spack/test/__init__.py index cb75f15ca1..7da3895cec 100644 --- a/lib/spack/spack/test/__init__.py +++ b/lib/spack/spack/test/__init__.py @@ -104,7 +104,7 @@ def run(names, outputDir, verbose=False): succeeded = not tally.failCount and not tally.errorCount tty.msg("Tests Complete.", - "%5d tests run" % tally.numberOfTests, + "%5d tests run" % tally.numberOfTestsRun, "%5d failures" % tally.failCount, "%5d errors" % tally.errorCount) diff --git a/lib/spack/spack/test/tally_plugin.py b/lib/spack/spack/test/tally_plugin.py index c167d58529..9ca898c47c 100644 --- a/lib/spack/spack/test/tally_plugin.py +++ b/lib/spack/spack/test/tally_plugin.py @@ -35,9 +35,9 @@ class Tally(Plugin): self.failCount = 0 self.errorCount = 0 - # TODO: this doesn't account for the possibility of skipped tests @property - def numberOfTests(self): + def numberOfTestsRun(self): + """Excludes skipped tests""" return self.errorCount + self.failCount + self.successCount def options(self, parser, env=os.environ): -- cgit v1.2.3-70-g09d2