From fcac95b0654a84151ad51a9123f74e8cdfcf8d26 Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Thu, 14 Oct 2021 01:27:24 +0200 Subject: Don't run lsb_release on linux (#26707) Running `lsb_release` on Linux takes about 50ms because it is written in Python. We do not use the output, so this change makes use not call it. --- lib/spack/external/__init__.py | 1 + lib/spack/external/distro.py | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/spack/external/__init__.py b/lib/spack/external/__init__.py index b2acccd8cc..5b3e1741c8 100644 --- a/lib/spack/external/__init__.py +++ b/lib/spack/external/__init__.py @@ -38,6 +38,7 @@ distro * Homepage: https://pypi.python.org/pypi/distro * Usage: Provides a more stable linux distribution detection. * Version: 1.0.4 (last version supporting Python 2.6) +* Note: Patched to disable lsb_release by default to improve Spack's startup time. functools --------- diff --git a/lib/spack/external/distro.py b/lib/spack/external/distro.py index e3805de75f..24da74e537 100644 --- a/lib/spack/external/distro.py +++ b/lib/spack/external/distro.py @@ -12,6 +12,8 @@ # See the License for the specific language governing permissions and # limitations under the License. +# Spack managed modifications: use include_lsb=False by default. + """ The ``distro`` package (``distro`` stands for Linux Distribution) provides information about the Linux distribution it runs on, such as a reliable @@ -1072,7 +1074,7 @@ class LinuxDistribution(object): return distro_info -_distro = LinuxDistribution() +_distro = LinuxDistribution(include_lsb=False) def main(): -- cgit v1.2.3-60-g2f50