From 24c01d57cfb99946eff3af7ec62b71ae6ec72ed8 Mon Sep 17 00:00:00 2001 From: Todd Gamblin Date: Thu, 8 Jul 2021 15:12:30 -0700 Subject: imports: sort imports everywhere in Spack (#24695) * fix remaining flake8 errors * imports: sort imports everywhere in Spack We enabled import order checking in #23947, but fixing things manually drives people crazy. This used `spack style --fix --all` from #24071 to automatically sort everything in Spack so PR submitters won't have to deal with it. This should go in after #24071, as it assumes we're using `isort`, not `flake8-import-order` to order things. `isort` seems to be more flexible and allows `llnl` mports to be in their own group before `spack` ones, so this seems like a good switch. --- share/spack/qa/flake8_formatter.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'share') diff --git a/share/spack/qa/flake8_formatter.py b/share/spack/qa/flake8_formatter.py index 73aa986af2..0611d54019 100644 --- a/share/spack/qa/flake8_formatter.py +++ b/share/spack/qa/flake8_formatter.py @@ -1,7 +1,8 @@ import re import sys -import pycodestyle from collections import defaultdict + +import pycodestyle from flake8.formatting.default import Pylint from flake8.style_guide import Violation -- cgit v1.2.3-70-g09d2