From d51af675ef345a191aa995b82609e5f6776184a3 Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Wed, 19 Apr 2023 23:17:47 +0200 Subject: make version(...) kwargs explicit (#36998) - [x] Replace `version(ver, checksum=None, **kwargs)` signature with `version(ver, checksum=None, *, sha256=..., ...)` explicitly listing all arguments. - [x] Fix various issues in packages: - `tags` instead of `tag` - `default` instead of `preferred` - `sha26` instead of `sha256` - etc Also, use `sha256=...` consistently. Note: setting `sha256` currently doesn't validate the checksum length, so you could do `sha256="a"*32` and it would get checked as `md5`... but that's something for another PR. --- var/spack/repos/builtin.mock/packages/a/package.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'var/spack/repos/builtin.mock/packages/a/package.py') diff --git a/var/spack/repos/builtin.mock/packages/a/package.py b/var/spack/repos/builtin.mock/packages/a/package.py index 52b02cbe64..ba6064bd59 100644 --- a/var/spack/repos/builtin.mock/packages/a/package.py +++ b/var/spack/repos/builtin.mock/packages/a/package.py @@ -12,8 +12,8 @@ class A(AutotoolsPackage): homepage = "http://www.example.com" url = "http://www.example.com/a-1.0.tar.gz" - version("1.0", "0123456789abcdef0123456789abcdef") - version("2.0", "abcdef0123456789abcdef0123456789") + version("1.0", md5="0123456789abcdef0123456789abcdef") + version("2.0", md5="abcdef0123456789abcdef0123456789") variant( "foo", description="", values=any_combination_of("bar", "baz", "fee").with_default("bar") -- cgit v1.2.3-60-g2f50