From d51af675ef345a191aa995b82609e5f6776184a3 Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Wed, 19 Apr 2023 23:17:47 +0200 Subject: make version(...) kwargs explicit (#36998) - [x] Replace `version(ver, checksum=None, **kwargs)` signature with `version(ver, checksum=None, *, sha256=..., ...)` explicitly listing all arguments. - [x] Fix various issues in packages: - `tags` instead of `tag` - `default` instead of `preferred` - `sha26` instead of `sha256` - etc Also, use `sha256=...` consistently. Note: setting `sha256` currently doesn't validate the checksum length, so you could do `sha256="a"*32` and it would get checked as `md5`... but that's something for another PR. --- .../builtin.mock/packages/variant-on-dependency-condition-a/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'var/spack/repos/builtin.mock/packages/variant-on-dependency-condition-a/package.py') diff --git a/var/spack/repos/builtin.mock/packages/variant-on-dependency-condition-a/package.py b/var/spack/repos/builtin.mock/packages/variant-on-dependency-condition-a/package.py index 32bd2eb233..556a2d0c1e 100644 --- a/var/spack/repos/builtin.mock/packages/variant-on-dependency-condition-a/package.py +++ b/var/spack/repos/builtin.mock/packages/variant-on-dependency-condition-a/package.py @@ -16,6 +16,6 @@ class VariantOnDependencyConditionA(Package): homepage = "https://www.example.org" url = "https://example.org/files/v3.4/cmake-3.4.3.tar.gz" - version("1.0", "4cb3ff35b2472aae70f542116d616e63") + version("1.0", md5="4cb3ff35b2472aae70f542116d616e63") variant("x", default=True, description="?") -- cgit v1.2.3-60-g2f50