From c110bcc5af64a0d93200b58861a9cb65c751ffbd Mon Sep 17 00:00:00 2001 From: Chris Green Date: Tue, 2 May 2023 20:18:30 -0500 Subject: libintl, iconv, gettext: account for libc provider and externals (#35450) * libiconv can be provided by libc, so update packages which depend on libiconv to require the iconv virtual instead * Many packages need special consideration when locating iconv depending on whether it is provided by libc (no prefix provided) or the libiconv package (in that case we want to provide a prefix) * It was also noticed that when an iconv external was provided, that there was interference with linking (this should generally be handled by Spack's compiler wrappers and bears further investigation) * Like iconv, libintl can be provided by libc or another package, namely gettext. It is not converted to a provider like libiconv because it provides additional routines. The logic is similar to that of iconv but instead of checking the provider, we check whether the gettext installation includes libintl. --- var/spack/repos/builtin/packages/bind9/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'var/spack/repos/builtin/packages/bind9/package.py') diff --git a/var/spack/repos/builtin/packages/bind9/package.py b/var/spack/repos/builtin/packages/bind9/package.py index 8320fa3e59..68b1e9da44 100644 --- a/var/spack/repos/builtin/packages/bind9/package.py +++ b/var/spack/repos/builtin/packages/bind9/package.py @@ -19,7 +19,7 @@ class Bind9(AutotoolsPackage): depends_on("libuv", type="link") depends_on("pkgconfig", type="build") depends_on("openssl", type="link") - depends_on("libiconv", type="link") + depends_on("iconv", type="link") def configure_args(self): args = [ -- cgit v1.2.3-60-g2f50