From 027632cbac1cfa42e2f66b53ae6c3f22bcce630e Mon Sep 17 00:00:00 2001 From: George Hartzell Date: Wed, 19 Oct 2016 12:28:26 -0700 Subject: Fix cdd package definition, dotted is a property (#2054) Things that accessed the cdd package, such as `spack info cdd run tripped over a buglet in the *cdd* package, causing them to exit with something like this: ``` Caused by: TypeError: 'str' object is not callable File "/rss/spack/lib/spack/spack/repository.py", line 584, in get self._instances[key] = package_class(copy) File "/rss/spack/lib/spack/spack/package.py", line 398, in __init__ f = fs.for_package_version(self, self.version) File "/rss/spack/lib/spack/spack/fetch_strategy.py", line 852, in for_package_version attrs['url'] = pkg.url_for_version(version) File "/rss/spack/var/spack/repos/builtin/packages/cdd/package.py", line 40, in url_for_version str(version.dotted()).replace('.', '')) ``` @tgamblin pointed out that `dotted` is a property, not a functin call and that the parentheses are therefor inappropriate. This deletes the parentheses. `spack info cdd` now works for me. --- var/spack/repos/builtin/packages/cdd/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/cdd/package.py b/var/spack/repos/builtin/packages/cdd/package.py index 8896942bae..bff942af25 100644 --- a/var/spack/repos/builtin/packages/cdd/package.py +++ b/var/spack/repos/builtin/packages/cdd/package.py @@ -37,7 +37,7 @@ class Cdd(Package): def url_for_version(self, version): return ("ftp://ftp.ifor.math.ethz.ch/pub/fukuda/cdd/cdd-%s.tar.gz" % - str(version.dotted()).replace('.', '')) + str(version.dotted).replace('.', '')) version('0.61a', '22c24a7a9349dd7ec0e24531925a02d9') -- cgit v1.2.3-60-g2f50