From 051d15f7772b7b2add1c5dc638bc4f87b75a5eba Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Tue, 27 Jun 2017 12:34:52 +0100 Subject: BUG: inconsistent -fPIC causes adios/mxml linkage problem (fix #4605) (#4606) - Thanks to pointer from @adamjstewart - can avoid this either by avoiding an external mxml dependency, or by making certain that they both use consistent code generation. The adios package uses '-fPIC' for python linkage and this seems to require the same for mxml too. If the adios-internal version of mxml is used, it has the same flags for both. --- var/spack/repos/builtin/packages/mxml/package.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/mxml/package.py b/var/spack/repos/builtin/packages/mxml/package.py index c0ff5f6cd9..e8b87e52c1 100644 --- a/var/spack/repos/builtin/packages/mxml/package.py +++ b/var/spack/repos/builtin/packages/mxml/package.py @@ -48,5 +48,9 @@ class Mxml(AutotoolsPackage): return 'https://github.com/michaelrsweet/mxml/releases/download/release-{0}/mxml-{0}.tar.gz'.format(version) def configure_args(self): - # Default is non-shared, but avoid any future surprises - return ['--disable-shared'] + return [ + # ADIOS build with -fPIC, so we need it too (avoid linkage issue) + 'CFLAGS=-fPIC', + # Default is non-shared, but avoid any future surprises + '--disable-shared', + ] -- cgit v1.2.3-60-g2f50