From 0b6f995187cbcf17d9aa4c11be1b8bc3a4d678cf Mon Sep 17 00:00:00 2001 From: Sreenivasa Murthy Kolam <67086238+srekolam@users.noreply.github.com> Date: Thu, 15 Oct 2020 21:11:48 +0530 Subject: Update migraphx for rocm 3.8 (#19300) * update to migraphx for rocm_3.7.0 and rocm_3.8.0 * fix flake8 errors * address review comments * review changes * removed the msgpack,mentioned twice --- var/spack/repos/builtin/packages/half/package.py | 4 +- var/spack/repos/builtin/packages/hip/package.py | 4 +- .../repos/builtin/packages/migraphx/package.py | 49 ++++++++++++++++++++++ 3 files changed, 53 insertions(+), 4 deletions(-) create mode 100644 var/spack/repos/builtin/packages/migraphx/package.py (limited to 'var') diff --git a/var/spack/repos/builtin/packages/half/package.py b/var/spack/repos/builtin/packages/half/package.py index 14c12cc0cd..5a3daf1c4f 100644 --- a/var/spack/repos/builtin/packages/half/package.py +++ b/var/spack/repos/builtin/packages/half/package.py @@ -22,8 +22,8 @@ class Half(Package): maintainers = ['bvanessen'] version('2.1.0', sha256='ad1788afe0300fa2b02b0d1df128d857f021f92ccf7c8bddd07812685fa07a25') - - patch('f16fix.patch') + version('1.12.0', sha256='cdd70d3bf3fe091b688e7ab3f48471c881a197d2c186c95cca8bf156961fb41c') + patch('f16fix.patch', when='@2.1.0') def install(self, spec, prefix): mkdirp(prefix.include) diff --git a/var/spack/repos/builtin/packages/hip/package.py b/var/spack/repos/builtin/packages/hip/package.py index 799415483e..7bb62f8cfd 100644 --- a/var/spack/repos/builtin/packages/hip/package.py +++ b/var/spack/repos/builtin/packages/hip/package.py @@ -29,9 +29,9 @@ class Hip(CMakePackage): depends_on('hip-rocclr@' + ver, type='build', when='@' + ver) depends_on('hsakmt-roct@' + ver, type='build', when='@' + ver) depends_on('hsa-rocr-dev@' + ver, type='link', when='@' + ver) - depends_on('comgr@' + ver, when='@' + ver) + depends_on('comgr@' + ver, type=('build', 'link', 'run'), when='@' + ver) depends_on('llvm-amdgpu@' + ver, type='build', when='@' + ver) - depends_on('rocm-device-libs@' + ver, type='build', when='@' + ver) + depends_on('rocm-device-libs@' + ver, type=('build', 'link', 'run'), when='@' + ver) depends_on('rocminfo@' + ver, type='build', when='@' + ver) # Notice: most likely this will only be a hard dependency on 3.7.0 diff --git a/var/spack/repos/builtin/packages/migraphx/package.py b/var/spack/repos/builtin/packages/migraphx/package.py new file mode 100644 index 0000000000..90b438dbf0 --- /dev/null +++ b/var/spack/repos/builtin/packages/migraphx/package.py @@ -0,0 +1,49 @@ +# Copyright 2013-2020 Lawrence Livermore National Security, LLC and other +# Spack Project Developers. See the top-level COPYRIGHT file for details. +# +# SPDX-License-Identifier: (Apache-2.0 OR MIT) + +from spack import * + + +class Migraphx(CMakePackage): + """ AMD's graph optimization engine.""" + + homepage = "https://github.com/ROCmSoftwarePlatform/AMDMIGraphX" + url = "https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/archive/rocm-3.5.0.tar.gz" + + maintainers = ['srekolam', 'arjun-raj-kuppala'] + + def url_for_version(self, version): + url = "https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/archive/{0}.tar.gz" + if version > Version('3.5'): + return url.format(version) + else: + return url.format('rocm-' + version) + + version('3.8.0', sha256='08fa991349a2b95364b0a69be7960580c3e3fde2fda0f0c67bc41429ea2d67a0') + version('3.7.0', sha256='697c3c7babaa025eaabec630dbd8a87d10dc4fe35fafa3b0d3463aaf1fc46399') + version('3.5.0', sha256='5766f3b262468c500be5051a056811a8edfa741734a5c08c4ecb0337b7906377') + + variant('build_type', default='Release', values=("Release", "Debug"), description='CMake build type') + + depends_on('cmake@3:', type='build') + depends_on('protobuf', type='link') + depends_on('blaze', type='build') + depends_on('nlohmann-json', type='link') + depends_on('py-pybind11', type='build') + depends_on('msgpack-c', type='link') + depends_on('half@1.12.0', type='link') + for ver in ['3.5.0', '3.7.0', '3.8.0']: + depends_on('hip@' + ver, type='build', when='@' + ver) + depends_on('rocm-cmake@' + ver, type='build', when='@' + ver) + depends_on('llvm-amdgpu@' + ver, type='build', when='@' + ver) + depends_on('rocblas@' + ver, type='link', when='@' + ver) + depends_on('miopen-hip@' + ver, type='link', when='@' + ver) + + def cmake_args(self): + args = [ + '-DCMAKE_CXX_COMPILER={0}/bin/clang++' + .format(self.spec['llvm-amdgpu'].prefix) + ] + return args -- cgit v1.2.3-70-g09d2