From 11b3ce27b7dbd76014955f36f8d6097498bf58be Mon Sep 17 00:00:00 2001 From: "Adam J. Stewart" Date: Wed, 16 Aug 2017 12:25:37 -0500 Subject: Add better generator support to CMakePackage (#4988) * Add better generator support to CMakePackage * List valid CMake generators on error --- var/spack/repos/builtin/packages/archer/package.py | 14 +++----------- .../repos/builtin/packages/llvm-openmp-ompt/package.py | 15 +++------------ 2 files changed, 6 insertions(+), 23 deletions(-) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/archer/package.py b/var/spack/repos/builtin/packages/archer/package.py index 0883191277..f5e4fbf8c1 100644 --- a/var/spack/repos/builtin/packages/archer/package.py +++ b/var/spack/repos/builtin/packages/archer/package.py @@ -36,22 +36,14 @@ class Archer(CMakePackage): depends_on('cmake@3.4.3:', type='build') depends_on('llvm') - depends_on('ninja', type='build') + depends_on('ninja@1.5:', type='build') depends_on('llvm-openmp-ompt') + generator = 'Ninja' + def cmake_args(self): return [ - '-G', 'Ninja', '-DCMAKE_C_COMPILER=clang', '-DCMAKE_CXX_COMPILER=clang++', '-DOMP_PREFIX:PATH=%s' % self.spec['llvm-openmp-ompt'].prefix, ] - - # TODO: Add better ninja support to CMakePackage - def build(self, spec, prefix): - with working_dir(self.build_directory): - ninja() - - def install(self, spec, prefix): - with working_dir(self.build_directory): - ninja('install') diff --git a/var/spack/repos/builtin/packages/llvm-openmp-ompt/package.py b/var/spack/repos/builtin/packages/llvm-openmp-ompt/package.py index 8039ec1717..edbd9f04e1 100644 --- a/var/spack/repos/builtin/packages/llvm-openmp-ompt/package.py +++ b/var/spack/repos/builtin/packages/llvm-openmp-ompt/package.py @@ -44,24 +44,15 @@ class LlvmOpenmpOmpt(CMakePackage): depends_on('cmake@2.8:', type='build') depends_on('llvm') - depends_on('ninja', type='build') + depends_on('ninja@1.5:', type='build') + + generator = 'Ninja' def cmake_args(self): return [ - '-G', 'Ninja', '-DCMAKE_C_COMPILER=clang', '-DCMAKE_CXX_COMPILER=clang++', - '-DCMAKE_BUILD_TYPE=Release', '-DLIBOMP_OMPT_SUPPORT=on', '-DLIBOMP_OMPT_BLAME=on', '-DLIBOMP_OMPT_TRACE=on' ] - - # TODO: Add better ninja support to CMakePackage - def build(self, spec, prefix): - with working_dir(self.build_directory): - ninja() - - def install(self, spec, prefix): - with working_dir(self.build_directory): - ninja('install') -- cgit v1.2.3-70-g09d2