From 1215c3b20c28edfb8bcb21ad764b0940fa78e268 Mon Sep 17 00:00:00 2001 From: "Adam J. Stewart" Date: Tue, 18 Jul 2017 11:58:19 -0500 Subject: Change path to CMakeLists.txt to be relative to root, not pwd (#4420) * Change path to CMakeLists.txt to be relative to root, not pwd * Changes requested during code review * Revert back to old naming of root_cmakelists_dir * Make relative directory more clear in docs * Revert change causing build_type AttributeError * Fix forgotten abs_path var * Update CLHEP with new relative path * Update more packages with new root_cmakelists_dir syntax --- var/spack/repos/builtin/packages/bcl2fastq2/package.py | 2 +- var/spack/repos/builtin/packages/clfft/package.py | 6 ++---- var/spack/repos/builtin/packages/clhep/package.py | 2 +- var/spack/repos/builtin/packages/cpprestsdk/package.py | 2 +- var/spack/repos/builtin/packages/isaac-server/package.py | 6 ++---- var/spack/repos/builtin/packages/isaac/package.py | 6 ++---- var/spack/repos/builtin/packages/quinoa/package.py | 2 +- var/spack/repos/builtin/packages/spades/package.py | 4 +--- 8 files changed, 11 insertions(+), 19 deletions(-) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/bcl2fastq2/package.py b/var/spack/repos/builtin/packages/bcl2fastq2/package.py index 1a7fff360c..7af1815757 100644 --- a/var/spack/repos/builtin/packages/bcl2fastq2/package.py +++ b/var/spack/repos/builtin/packages/bcl2fastq2/package.py @@ -59,7 +59,7 @@ class Bcl2fastq2(Package): # libexslt bits. patch('cxxConfigure-cmake.patch') - root_cmakelists_dir = '../src' + root_cmakelists_dir = 'src' def url_for_version(self, version): url = "https://support.illumina.com/content/dam/illumina-support/documents/downloads/software/bcl2fastq/bcl2fastq2-v{0}-tar.zip" diff --git a/var/spack/repos/builtin/packages/clfft/package.py b/var/spack/repos/builtin/packages/clfft/package.py index 271d5c389a..5a03a3b07f 100644 --- a/var/spack/repos/builtin/packages/clfft/package.py +++ b/var/spack/repos/builtin/packages/clfft/package.py @@ -31,10 +31,6 @@ class Clfft(CMakePackage): homepage = "https://github.com/clMathLibraries/clFFT" url = "https://github.com/clMathLibraries/clFFT/archive/v2.12.2.tar.gz" - @property - def root_cmakelists_dir(self): - return join_path(self.stage.source_path, 'src') - version('2.12.2', '9104d85f9f2f3c58dd8efc0e4b06496f') variant('client', default=True, @@ -43,6 +39,8 @@ class Clfft(CMakePackage): depends_on('opencl@1.2:') depends_on('boost@1.33.0:', when='+client') + root_cmakelists_dir = 'src' + def cmake_args(self): spec = self.spec diff --git a/var/spack/repos/builtin/packages/clhep/package.py b/var/spack/repos/builtin/packages/clhep/package.py index 4d8fd14f3b..e9bf85c97f 100644 --- a/var/spack/repos/builtin/packages/clhep/package.py +++ b/var/spack/repos/builtin/packages/clhep/package.py @@ -63,7 +63,7 @@ class Clhep(CMakePackage): '%s/%s/CLHEP/CMakeLists.txt' % (self.stage.path, self.spec.version)) - root_cmakelists_dir = '../CLHEP' + root_cmakelists_dir = 'CLHEP' def build_type(self): spec = self.spec diff --git a/var/spack/repos/builtin/packages/cpprestsdk/package.py b/var/spack/repos/builtin/packages/cpprestsdk/package.py index 6cb378a2f3..b5d96ff480 100644 --- a/var/spack/repos/builtin/packages/cpprestsdk/package.py +++ b/var/spack/repos/builtin/packages/cpprestsdk/package.py @@ -38,4 +38,4 @@ class Cpprestsdk(CMakePackage): depends_on('boost') - root_cmakelists_dir = '../Release' + root_cmakelists_dir = 'Release' diff --git a/var/spack/repos/builtin/packages/isaac-server/package.py b/var/spack/repos/builtin/packages/isaac-server/package.py index c13a1d8aec..baa79cf673 100644 --- a/var/spack/repos/builtin/packages/isaac-server/package.py +++ b/var/spack/repos/builtin/packages/isaac-server/package.py @@ -31,10 +31,6 @@ class IsaacServer(CMakePackage): homepage = "http://computationalradiationphysics.github.io/isaac/" url = "https://github.com/ComputationalRadiationPhysics/isaac/archive/v1.3.0.tar.gz" - @property - def root_cmakelists_dir(self): - return join_path(self.stage.source_path, 'server') - version('develop', branch='dev', git='https://github.com/ComputationalRadiationPhysics/isaac.git') version('master', branch='master', @@ -51,3 +47,5 @@ class IsaacServer(CMakePackage): depends_on('boost@1.56:', type='link') depends_on('libwebsockets@2.1.1:', type='link') # depends_on('gstreamer@1.0', when='+gstreamer') + + root_cmakelists_dir = 'server' diff --git a/var/spack/repos/builtin/packages/isaac/package.py b/var/spack/repos/builtin/packages/isaac/package.py index 33546d19b0..a06a782e46 100644 --- a/var/spack/repos/builtin/packages/isaac/package.py +++ b/var/spack/repos/builtin/packages/isaac/package.py @@ -31,10 +31,6 @@ class Isaac(CMakePackage): homepage = "http://computationalradiationphysics.github.io/isaac/" url = "https://github.com/ComputationalRadiationPhysics/isaac/archive/v1.3.0.tar.gz" - @property - def root_cmakelists_dir(self): - return join_path(self.stage.source_path, 'lib') - version('develop', branch='dev', git='https://github.com/ComputationalRadiationPhysics/isaac.git') version('master', branch='master', @@ -55,3 +51,5 @@ class Isaac(CMakePackage): # depends_on('alpaka', when='+alpaka') depends_on('icet', type='link') depends_on('mpi', type='link') + + root_cmakelists_dir = 'lib' diff --git a/var/spack/repos/builtin/packages/quinoa/package.py b/var/spack/repos/builtin/packages/quinoa/package.py index e65d347759..eb41bb8b37 100644 --- a/var/spack/repos/builtin/packages/quinoa/package.py +++ b/var/spack/repos/builtin/packages/quinoa/package.py @@ -55,7 +55,7 @@ class Quinoa(CMakePackage): depends_on("pstreams") depends_on("pegtl") - root_cmakelists_dir = '../src' + root_cmakelists_dir = 'src' def build_type(self): spec = self.spec diff --git a/var/spack/repos/builtin/packages/spades/package.py b/var/spack/repos/builtin/packages/spades/package.py index c7e4469f5e..443436d3ae 100644 --- a/var/spack/repos/builtin/packages/spades/package.py +++ b/var/spack/repos/builtin/packages/spades/package.py @@ -40,6 +40,4 @@ class Spades(CMakePackage): conflicts('%gcc@7.1.0:') - @property - def root_cmakelists_dir(self): - return join_path(self.stage.source_path, 'src') + root_cmakelists_dir = 'src' -- cgit v1.2.3-70-g09d2