From 5b23c5dcc070e11828e4e1ff773c4a68e2d7386c Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Tue, 18 Jul 2023 18:45:14 +0200 Subject: buildcache push: make --allow-root the default and deprecate the option (#38878) Without --allow-root spack cannot push binaries that contain paths in binaries. This flag is almost always needed, so there is no point of requiring users to spell it out. Even without --allow-root, rpaths would still have to be patched, so the flag is not there to guarantee binaries are not modified on install. This commit makes --allow-root the default, and drops the code required for it. It also deprecates `spack buildcache preview`, since the command made sense only with --allow-root. As a side effect, Spack no longer depends on binutils for relocation --- var/spack/repos/builtin/packages/spack/package.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/spack/package.py b/var/spack/repos/builtin/packages/spack/package.py index e2a6c1d830..01acba8705 100644 --- a/var/spack/repos/builtin/packages/spack/package.py +++ b/var/spack/repos/builtin/packages/spack/package.py @@ -71,8 +71,8 @@ class Spack(Package): depends_on("lmod@7.5.12:", type="run", when="@0.18:") # Buildcache - # We really just need the 'strings' from binutils - depends_on("binutils", type="run") + # We really just need the 'strings' from binutils for older versions of spack + depends_on("binutils", type="run", when="@:0.20") depends_on("gnupg", type="run") depends_on("patchelf", type="run", when="platform=linux") depends_on("patchelf", type="run", when="platform=cray") -- cgit v1.2.3-60-g2f50