From 7036f41ea5f4452b7e1ea87691ed522b55437847 Mon Sep 17 00:00:00 2001 From: Xavier Delaruelle Date: Mon, 31 Aug 2020 17:43:31 +0200 Subject: environment-modules: fix version 4.5.2 install (#18421) `configure` script of Modules 4.5.2 is a bit too strict and breaks when special options like `--disable-dependency-tracking` are set. This issue will be fixed on Modules project starting version 4.5.3 (cea-hpc/modules#354). This change adapts `configure` options set when installing version 4.5.2 to avoid options unrecognized on this version. Fix #18420 --- .../repos/builtin/packages/environment-modules/package.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'var') diff --git a/var/spack/repos/builtin/packages/environment-modules/package.py b/var/spack/repos/builtin/packages/environment-modules/package.py index d2d1853304..0bf1f56b9a 100644 --- a/var/spack/repos/builtin/packages/environment-modules/package.py +++ b/var/spack/repos/builtin/packages/environment-modules/package.py @@ -64,12 +64,18 @@ class EnvironmentModules(Package): # It looks for tclConfig.sh "--with-tcl=" + tcl_lib_dir, "--with-tcl-ver={0}.{1}".format(*tcl.version.version[0:2]), - '--disable-dependency-tracking', - '--disable-silent-rules', '--disable-versioning', '--datarootdir=' + prefix.share ] + # ./configure script on version 4.5.2 breaks when specific options are + # set (see https://github.com/cea-hpc/modules/issues/354) + if not spec.satisfies('@4.5.2'): + config_args.extend([ + '--disable-dependency-tracking', + '--disable-silent-rules' + ]) + if '~X' in spec: config_args = ['--without-x'] + config_args -- cgit v1.2.3-70-g09d2